Default repo substitution doesn't work with the examples

[WoLfulus]

Expected behavior

Values from the examples matches the return value from SubstituteDefaultRepoIntoImage function

Actual behavior

The last two examples doesn't return the same value.

Example 3 returns gcr.io/k8s-skaffold/gcr.io/k8s-skaffold/skaffold-example1 instead of gcr.io/k8s-skaffold/skaffold-example1
Example 4 returns gcr.io/k8s-skaffold/myimage/gcr.io/k8s-skaffold/skaffold-example1 instead of gcr.io/k8s-skaffold/myimage/skaffold-example1

Also, shouldn't - and _ be accepted as a valid character here

skaffold/pkg/skaffold/util/image.go

Line 28 in 96ac37e

const prefixRegexStr = "gcr.io/[a-zA-Z]+/"

?

[balopat]

Thanks for filing the issue!
What is your default-repo setting/exact command?

[WoLfulus]

I wasn't using skaffold at the time I saw this. I just compiled the code and invoked it with the given examples on the website.

I was trying to replicate the behaviour in JavaScript because I'm working on a project that needs the image name that matches what skaffold generates. BTW: It would be nice to have a way to specify the FQIN for each container (skipping taggers)

[nkubala]

@WoLfulus thanks for pointing this out. opened a PR to fix the regex.

[WoLfulus]

Thank you!