Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold init --analyze --XXenableJibInit never exits if JDK not installed #5493

Closed
j-windsor opened this issue Mar 4, 2021 · 2 comments · Fixed by #5725
Closed

skaffold init --analyze --XXenableJibInit never exits if JDK not installed #5493

j-windsor opened this issue Mar 4, 2021 · 2 comments · Fixed by #5725
Labels
area/init build/jib fixit kind/bug Something isn't working priority/p2 May take a couple of releases

Comments

@j-windsor
Copy link

Expected behavior

command exits not showing jib build as an option

Actual behavior

command never exits

Information

  • Skaffold version: v1.20.0
  • Operating system: macOS 11.2 (M1 mac)
  • Installed via: Cloud Code

Steps to reproduce the behavior

  1. ensure JDK is not installed
  2. open Cloud Code java hello world sample.
  3. run skaffold init --analyze --XXenableJibInit
  4. wait a long time...
@briandealwis briandealwis added area/init build/jib kind/bug Something isn't working priority/p1 High impact feature/bug. labels Mar 6, 2021
@briandealwis
Copy link
Member

Noticed in #5380 too. This isn't easily detectable as /usr/bin/java exists. I suppose we could see if JAVA_HOME is set, and otherwise run java -version and see if it fails.

@j-windsor
Copy link
Author

Yeah I ran into this issue while testing on M1 Mac and could repro on Intel Mac. The stalling skaffold init causes the Cloud Code skaffold setup UI to stall out and it is unusable. It also stalls out on skaffold debug or skaffold dev when Jib is selected as the builder but JDK is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init build/jib fixit kind/bug Something isn't working priority/p2 May take a couple of releases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants