Revisit alwaysSucceedWhenCancelled to succeed if error is context cancelled at all times.

[tejal29]

When refactoring code for #5537, I notice alwaysSucceedWhenCancelled is a little confusing and returns nil only if ctx.Err is cancelled. There are tests in place e.g. here which rely on this behavior.

This bug is to revisit this and remove the extra check in main.

// alwaysSucceedWhenCancelled returns nil if the context was cancelled.
// If the error is due to cancellation, return it as it gets swallowed
// in skaffold main.
// For all other errors, pass through known errors.
// TODO: Return nil if error is `context.Cancelled` and remove check in main.
func alwaysSucceedWhenCancelled(ctx context.Context, runCtx *runcontext.RunContext, err error) error {
	if err == nil {
		return err
	}
	// if the context was cancelled act as if all is well
	if ctx.Err() == context.Canceled {
		return nil
	} else if err == context.Canceled {
		return err
	}
	return sErrors.ShowAIError(runCtx, err)
}