Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the Kaniko builder #671

Closed
4 tasks done
r2d4 opened this issue Jun 11, 2018 · 7 comments
Closed
4 tasks done

Enhance the Kaniko builder #671

r2d4 opened this issue Jun 11, 2018 · 7 comments
Labels

Comments

@r2d4
Copy link
Contributor

r2d4 commented Jun 11, 2018

Namely

  • Surface some of the flags that have been added since the initial release
  • The option to use an existing cluster secret instead of creating one from a keyfile passed in.
  • Generate unique pod names
  • Configurable namespace for kaniko builder

cc @sharifelgamal @priyawadhwa

@JonnyBGod
Copy link

Also would be good to be able to use Kaniko by passing just the local context and destination skipping the need for a GC Bucket

@dlorenc
Copy link
Contributor

dlorenc commented Jun 13, 2018

A few other improvements:

  • Support a configurable namespace for kaniko
  • Improve secret management (specifying existing secrets, etc.)
  • Generate unique names for the pod (in case of errors with earlier versions, etc.)

@dlorenc
Copy link
Contributor

dlorenc commented Jun 19, 2018

A few other things left to do. Updated in the top comment to track in one spot.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 19, 2018

Also would be good to be able to use Kaniko by passing just the local context and destination skipping the need for a GC Bucket

I think that's more of a kaniko limitation than a skaffold issue - would you mind opening an issue in that repo with the use case?

@priyawadhwa
Copy link
Contributor

You can pass in a local directory as the build context to kaniko with the --context flag. I think skaffold would just have to mount the local context into the pod to be able to use it.

@dlorenc
Copy link
Contributor

dlorenc commented Jun 20, 2018

I think the problem would be first getting the source from the local machine into the cluster and onto the node,although it's true skaffold might be able to do that before starting the kaniko container.

@r2d4 r2d4 added the priority/p2 May take a couple of releases label Jun 29, 2018
@r2d4
Copy link
Contributor Author

r2d4 commented Jul 10, 2018

Closing this with #803, which upgrades the version to v0.2.0. We can track more specific feature requests in another issue.

@r2d4 r2d4 closed this as completed Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants