diff --git a/pkg/skaffold/config/util.go b/pkg/skaffold/config/util.go index b86446bdda2..17d8c7b494c 100644 --- a/pkg/skaffold/config/util.go +++ b/pkg/skaffold/config/util.go @@ -219,9 +219,9 @@ func GetDebugHelpersRegistry(configFile string) (string, error) { func isDefaultLocal(kubeContext string) bool { return kubeContext == constants.DefaultDockerForDesktopContext || kubeContext == constants.DefaultDockerDesktopContext || - cluster.GetClient().IsMinikube(kubeContext) || IsKindCluster(kubeContext) || - IsK3dCluster(kubeContext) + IsK3dCluster(kubeContext) || + cluster.GetClient().IsMinikube(kubeContext) } // IsImageLoadingRequired checks if the cluster requires loading images into it diff --git a/pkg/skaffold/config/util_test.go b/pkg/skaffold/config/util_test.go index 4ff0742acb2..0f3ec3c175f 100644 --- a/pkg/skaffold/config/util_test.go +++ b/pkg/skaffold/config/util_test.go @@ -18,11 +18,13 @@ package config import ( "fmt" + "os/exec" "path/filepath" "strings" "testing" "time" + "github.com/GoogleContainerTools/skaffold/pkg/skaffold/cluster" "github.com/GoogleContainerTools/skaffold/pkg/skaffold/util" "github.com/GoogleContainerTools/skaffold/pkg/skaffold/yaml" "github.com/GoogleContainerTools/skaffold/testutil" @@ -281,6 +283,8 @@ func TestIsDefaultLocal(t *testing.T) { } for _, test := range tests { testutil.Run(t, "", func(t *testutil.T) { + t.Override(&cluster.GetClient, func() cluster.Client { return fakeClient{} }) + local := isDefaultLocal(test.context) t.CheckDeepEqual(test.expectedLocal, local) @@ -288,6 +292,11 @@ func TestIsDefaultLocal(t *testing.T) { } } +type fakeClient struct{} + +func (fakeClient) IsMinikube(kubeContext string) bool { return kubeContext == "minikube" } +func (fakeClient) MinikubeExec(...string) (*exec.Cmd, error) { return nil, nil } + func TestIsImageLoadingRequired(t *testing.T) { tests := []struct { context string