Skip to content
This repository was archived by the owner on Jul 23, 2024. It is now read-only.

bug: tone option in Monet engine doesn't apply #677

Closed
2 tasks done
tfuxu opened this issue Dec 17, 2022 · 1 comment
Closed
2 tasks done

bug: tone option in Monet engine doesn't apply #677

tfuxu opened this issue Dec 17, 2022 · 1 comment
Labels
area/monet-engine type/bug Something isn't working
Milestone

Comments

@tfuxu
Copy link
Member

tfuxu commented Dec 17, 2022

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Information about this bug (or rather lack of sufficient code to handle this feature) originates from comments in issue #425 and has been later acknowledged in issue #406.
There currently isn't any code that would take changed by tone option colors and apply them into a resulting preset. It would be good to have this fixed before releasing new major version, as an option for changing tone of colors has been added with Monet engine way back in version 0.1.0.

To Reproduce

  1. Go to Monet tab in Gradience,
  2. Choose input image,
  3. Change tone of colors,
  4. Changed colors don't apply when Apply button is clicked

Expected behavior

Resulting preset should change accordingly to colors shown in Monet Palette.

Screenshots

No response

OS

Arch Linux

Version

main branch

Installation method

Manual using meson

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tfuxu tfuxu added this to the 0.4.0 milestone Dec 17, 2022
@tfuxu tfuxu added type/bug Something isn't working area/monet-engine labels Dec 17, 2022
@tfuxu tfuxu modified the milestones: 0.4.0, 0.8.0 Dec 23, 2022
@tfuxu tfuxu added this to Gradience Feb 3, 2023
@github-project-automation github-project-automation bot moved this to Todo in Gradience Feb 3, 2023
@tfuxu
Copy link
Member Author

tfuxu commented Feb 3, 2023

I'm disabling for now tone option, because it requires more involvement than I thought it would need, and we are releasing 0.4.0 soon, so instead of leaving it and confusing users, it will be disabled until we came up with a proper backend implementation. Also this could be linked to #709 as it would be re-added probably not sooner than in 1.0 release.

@tfuxu tfuxu closed this as completed Feb 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Gradience Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/monet-engine type/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant