Skip to content

Commit 39b019f

Browse files
committed
Remove revert for llvm/llvm-project#120115
1 parent f1e1866 commit 39b019f

9 files changed

+14
-12
lines changed

compiler/src/iree/compiler/Codegen/Common/CPU/CPUPrepareUkernels.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ static void tileNonPackedDimsFor3DPackOps(RewriterBase &rewriter,
7575
FailureOr<scf::SCFTilingResult> tilingResult =
7676
scf::tileUsingSCF(rewriter, tilingInterfaceOp, options);
7777
assert(succeeded(tilingResult));
78-
rewriter.replaceOp(packOp, tilingResult->replacements);
78+
rewriter.replaceOp(packOp, tilingResult->mergeResult.replacements);
7979
});
8080
}
8181

@@ -110,7 +110,7 @@ static void tileNonPackedDimsFor5DPUnpackOps(RewriterBase &rewriter,
110110
FailureOr<scf::SCFTilingResult> tilingResult =
111111
scf::tileUsingSCF(rewriter, tilingInterfaceOp, options);
112112
assert(succeeded(tilingResult));
113-
rewriter.replaceOp(unpackOp, tilingResult->replacements);
113+
rewriter.replaceOp(unpackOp, tilingResult->mergeResult.replacements);
114114
});
115115
}
116116

compiler/src/iree/compiler/Codegen/Common/DecomposePackUnPackOps.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ static LogicalResult commonRunOnOperation(
200200
unpackTilingOptions);
201201
if (failed(tilingResult))
202202
return WalkResult::interrupt();
203-
rewriter.replaceOp(op, tilingResult->replacements);
203+
rewriter.replaceOp(op, tilingResult->mergeResult.replacements);
204204
return WalkResult::advance();
205205
});
206206
if (status.wasInterrupted()) {

compiler/src/iree/compiler/Codegen/Common/GPU/GPUTensorTile.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class TileConsumerAndFuseInputProducer final
9090
}
9191

9292
// Replace the tiled op with replacements.
93-
rewriter.replaceOp(op, tilingResult->replacements);
93+
rewriter.replaceOp(op, tilingResult->mergeResult.replacements);
9494
filter.replaceLinalgTransformationFilter(rewriter,
9595
tilingResult->tiledOps.front());
9696

@@ -292,7 +292,7 @@ static LogicalResult tileParallelDims(mlir::FunctionOpInterface funcOp,
292292
if (failed(tilingResult)) {
293293
return tilingOp->emitOpError("failed to tile to scf.forall");
294294
}
295-
rewriter.replaceOp(tilingOp, tilingResult->replacements);
295+
rewriter.replaceOp(tilingOp, tilingResult->mergeResult.replacements);
296296
}
297297
return success();
298298
}

compiler/src/iree/compiler/Codegen/Common/GPU/GPUTileReduction.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,11 @@ static LogicalResult tileReduction(linalg::LinalgOp op) {
3838
sizes.push_back(rewriter.getIndexAttr(size));
3939
}
4040
rewriter.setInsertionPoint(op);
41-
FailureOr<scf::SCFReductionTilingResult> results = scf::tileReductionUsingScf(
41+
FailureOr<scf::SCFTilingResult> results = scf::tileReductionUsingScf(
4242
rewriter, cast<PartialReductionOpInterface>(op.getOperation()), sizes);
4343
if (failed(results))
4444
return failure();
45+
rewriter.replaceOp(op, results->mergeResult.replacements);
4546
return success();
4647
}
4748

compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPU2DScalableTo1DScalable.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ dropScalabilityFromUnsupportedOperations(mlir::FunctionOpInterface funcOp,
161161
setLoweringConfig(newOp, newLoweringConfig);
162162
}
163163

164-
rewriter.replaceOp(tilingOp, tilingResult->replacements);
164+
rewriter.replaceOp(tilingOp, tilingResult->mergeResult.replacements);
165165
}
166166
return success();
167167
}

compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUSplitReduction.cpp

+3-2
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ LogicalResult splitReductionImpl(Operation *op, int64_t size,
132132
LLVM_DEBUG(llvm::dbgs() << "failed on step 1 (SCFTiling)\n");
133133
return failure();
134134
}
135-
rewriter.replaceOp(linalgOp, tileResFirst->replacements);
135+
rewriter.replaceOp(linalgOp, tileResFirst->mergeResult.replacements);
136136

137137
// 2) Apply splitReduction on the single vector-length array.
138138
// splitReduction already replaces the op.
@@ -159,7 +159,8 @@ LogicalResult splitReductionImpl(Operation *op, int64_t size,
159159
LLVM_DEBUG(llvm::dbgs() << "failed on step 3 (SCFTiling)\n");
160160
return failure();
161161
}
162-
rewriter.replaceOp(splitRes->splitLinalgOp, tileRes->replacements);
162+
rewriter.replaceOp(splitRes->splitLinalgOp,
163+
tileRes->mergeResult.replacements);
163164
return success();
164165
}
165166

compiler/src/iree/compiler/Codegen/LLVMCPU/LLVMCPUTile.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void LLVMCPUTilePass::runOnOperation() {
101101
scf::tileUsingSCF(rewriter, op, options);
102102
if (failed(tiledResults))
103103
continue;
104-
rewriter.replaceOp(op, tiledResults->replacements);
104+
rewriter.replaceOp(op, tiledResults->mergeResult.replacements);
105105
}
106106

107107
RewritePatternSet patterns =

compiler/src/iree/compiler/Codegen/Transforms/Transforms.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1256,7 +1256,7 @@ LogicalResult tileLinalgOpsWithFilter(mlir::FunctionOpInterface funcOp,
12561256
for (auto tiledOp : tiledResults->tiledOps) {
12571257
filter.replaceLinalgTransformationFilter(rewriter, tiledOp);
12581258
}
1259-
rewriter.replaceOp(op, tiledResults->replacements);
1259+
rewriter.replaceOp(op, tiledResults->mergeResult.replacements);
12601260
}
12611261

12621262
return success();

0 commit comments

Comments
 (0)