Skip to content

Commit f3c4194

Browse files
hindessmdnwe
authored andcommitted
fix: typo
Signed-off-by: Mark Hindess <mark.hindess@gmail.com>
1 parent 87229d9 commit f3c4194

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

admin.go

+13-13
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,9 @@ func (ca *clusterAdmin) refreshController() (*Broker, error) {
196196
return ca.client.RefreshController()
197197
}
198198

199-
// isErrNoController returns `true` if the given error type unwraps to an
199+
// isErrNotController returns `true` if the given error type unwraps to an
200200
// `ErrNotController` response from Kafka
201-
func isErrNoController(err error) bool {
201+
func isErrNotController(err error) bool {
202202
return errors.Is(err, ErrNotController)
203203
}
204204

@@ -249,7 +249,7 @@ func (ca *clusterAdmin) CreateTopic(topic string, detail *TopicDetail, validateO
249249
request.Version = 1
250250
}
251251

252-
return ca.retryOnError(isErrNoController, func() error {
252+
return ca.retryOnError(isErrNotController, func() error {
253253
b, err := ca.Controller()
254254
if err != nil {
255255
return err
@@ -278,14 +278,14 @@ func (ca *clusterAdmin) CreateTopic(topic string, detail *TopicDetail, validateO
278278

279279
func (ca *clusterAdmin) DescribeTopics(topics []string) (metadata []*TopicMetadata, err error) {
280280
var response *MetadataResponse
281-
err = ca.retryOnError(isErrNoController, func() error {
281+
err = ca.retryOnError(isErrNotController, func() error {
282282
controller, err := ca.Controller()
283283
if err != nil {
284284
return err
285285
}
286286
request := NewMetadataRequest(ca.conf.Version, topics)
287287
response, err = controller.GetMetadata(request)
288-
if isErrNoController(err) {
288+
if isErrNotController(err) {
289289
_, _ = ca.refreshController()
290290
}
291291
return err
@@ -298,15 +298,15 @@ func (ca *clusterAdmin) DescribeTopics(topics []string) (metadata []*TopicMetada
298298

299299
func (ca *clusterAdmin) DescribeCluster() (brokers []*Broker, controllerID int32, err error) {
300300
var response *MetadataResponse
301-
err = ca.retryOnError(isErrNoController, func() error {
301+
err = ca.retryOnError(isErrNotController, func() error {
302302
controller, err := ca.Controller()
303303
if err != nil {
304304
return err
305305
}
306306

307307
request := NewMetadataRequest(ca.conf.Version, nil)
308308
response, err = controller.GetMetadata(request)
309-
if isErrNoController(err) {
309+
if isErrNotController(err) {
310310
_, _ = ca.refreshController()
311311
}
312312
return err
@@ -438,7 +438,7 @@ func (ca *clusterAdmin) DeleteTopic(topic string) error {
438438
request.Version = 1
439439
}
440440

441-
return ca.retryOnError(isErrNoController, func() error {
441+
return ca.retryOnError(isErrNotController, func() error {
442442
b, err := ca.Controller()
443443
if err != nil {
444444
return err
@@ -482,7 +482,7 @@ func (ca *clusterAdmin) CreatePartitions(topic string, count int32, assignment [
482482
request.Version = 1
483483
}
484484

485-
return ca.retryOnError(isErrNoController, func() error {
485+
return ca.retryOnError(isErrNotController, func() error {
486486
b, err := ca.Controller()
487487
if err != nil {
488488
return err
@@ -523,7 +523,7 @@ func (ca *clusterAdmin) AlterPartitionReassignments(topic string, assignment [][
523523
request.AddBlock(topic, int32(i), assignment[i])
524524
}
525525

526-
return ca.retryOnError(isErrNoController, func() error {
526+
return ca.retryOnError(isErrNotController, func() error {
527527
b, err := ca.Controller()
528528
if err != nil {
529529
return err
@@ -570,15 +570,15 @@ func (ca *clusterAdmin) ListPartitionReassignments(topic string, partitions []in
570570
request.AddBlock(topic, partitions)
571571

572572
var rsp *ListPartitionReassignmentsResponse
573-
err = ca.retryOnError(isErrNoController, func() error {
573+
err = ca.retryOnError(isErrNotController, func() error {
574574
b, err := ca.Controller()
575575
if err != nil {
576576
return err
577577
}
578578
_ = b.Open(ca.client.Config())
579579

580580
rsp, err = b.ListPartitionReassignments(request)
581-
if isErrNoController(err) {
581+
if isErrNotController(err) {
582582
_, _ = ca.refreshController()
583583
}
584584
return err
@@ -1204,7 +1204,7 @@ func (ca *clusterAdmin) AlterUserScramCredentials(u []AlterUserScramCredentialsU
12041204
}
12051205

12061206
var rsp *AlterUserScramCredentialsResponse
1207-
err := ca.retryOnError(isErrNoController, func() error {
1207+
err := ca.retryOnError(isErrNotController, func() error {
12081208
b, err := ca.Controller()
12091209
if err != nil {
12101210
return err

0 commit comments

Comments
 (0)