Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guestbook - Enabled for Request File Access #2043

Closed
posixeleni opened this issue Apr 17, 2015 · 19 comments · Fixed by #9599
Closed

Guestbook - Enabled for Request File Access #2043

posixeleni opened this issue Apr 17, 2015 · 19 comments · Fixed by #9599

Comments

@posixeleni
Copy link
Contributor

Users with restricted files would like to enable guestbook like functionality so that they can find out who and why someone would like to access their data. This will help inform the user on whether or not they should grant or reject access to a file.

This suggestion was requested by a user in our Google Community Forum: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/dataverse-community/Xn-SsIEaRf8/LwtvL8exXEAJ

@posixeleni posixeleni added this to the In Review - 4.x milestone Apr 17, 2015
@scolapasta scolapasta modified the milestones: In Review - Long Term, In Review - Short Term May 8, 2015
@sbarbosadataverse
Copy link

@eaquigley
@pdurbin

Contact from user today regarding this function. In 3.6, clicking on username allowed admins to see: names, affiliations, and email. Also mentioned they can't grant access to their users until this is resolved which bumps it up to high/critical request
We need a function that resembles this.

@mercecrosas
Copy link
Member

@eaquigley can you this to the In Design milestone, so we can push it to an upcoming release as soon as possible? This is urgent. From users the inability to verify users information is equivalent to the system being down because they cannot process requests.
@scolapasta this is high priority for an upcoming release.

@eaquigley eaquigley self-assigned this May 30, 2015
@eaquigley eaquigley modified the milestones: In Design, In Review May 30, 2015
@eaquigley
Copy link
Contributor

FRD and mock up needs to be done

@eaquigley
Copy link
Contributor

FRD: https://docs.google.com/document/d/1qoDTXXCIBtMgLbh_xSISNkfh5dvh_afB3kDNcEUIOEo/edit?usp=sharing

Part of this issue was solved in #2228 so this issue is now about having the guestbook recording entries that a dataset owner can review when a restricted file is requested for access.

@eaquigley eaquigley modified the milestones: Candidates for 4.3, In Design Jul 23, 2015
@eaquigley
Copy link
Contributor

FRD has been completed: https://docs.google.com/document/d/1qoDTXXCIBtMgLbh_xSISNkfh5dvh_afB3kDNcEUIOEo/edit?usp=sharing

Now just needs to be scheduled for development. No need for mockups as it is adding an extra step to an existing workflow.

@mercecrosas mercecrosas removed this from the Candidates for 4.3 milestone Nov 30, 2015
@mdmADA
Copy link
Contributor

mdmADA commented Oct 14, 2018

Hi Phil - It would be great to have ADA's code in the main code base. I would like to redesign some of it to make it more flexible as my first go at it was simply to quickly implement the functionality ADA needed in order to use Dataverse. Separating the requestbook database records from the guestbook database records, and tracking the full life cycle of a requestbook record would be on my agenda as part of that redesign.

Steve and I will need to discuss the best way forward from ADA's perspective so let's keep the discussion going over the next weeks.

Thanks!

@pdurbin
Copy link
Member

pdurbin commented Oct 14, 2018

@mdmADA sounds great. The main thing I wanted to convey is that you're on the right track. There's lot of interest in this feature. Thanks!

@mheppler mheppler removed Feature: File Upload & Handling UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Oct 15, 2018
@pdurbin pdurbin removed Type: Feature a feature request User Role: Depositor Creates datasets, uploads data, etc. labels Oct 19, 2018
@pdurbin
Copy link
Member

pdurbin commented Mar 28, 2019

@mdmADA hi! I just thought I'd mention that when I was at LibrePlanet last weekend I talked to a Dataverse user about the "requestbook" you have at ADA. For now, his work around is to make one file unrestricted, a PDF that he asks people to fill out to request access to the data. I think it's this PDF: https://dataverse.harvard.edu/file.xhtml?persistentId=doi:10.7910/DVN/KFT8EZ/ACLHGA . Anyway, he definitely sounded interested in the feature you have in production. 😄

@mdmADA
Copy link
Contributor

mdmADA commented Mar 28, 2019

Thanks for passing that on, @pdurbin.

ADA has had several organisations express interest in the Request Access feature so it is great to add another to the list! 👍

M.

@pdurbin
Copy link
Member

pdurbin commented May 21, 2019

@mdmADA hi! I see that you made pull request #5863 (thanks!) and that you have a number of questions in there so I dragged this to code review. I'm not sure if you're aware of this but we switched from Waffle as our kanban board to GitHub Projects: https://github.com/orgs/IQSS/projects/2

@djbrooke
Copy link
Contributor

Thanks @mdmADA - I'll move this back to the Community Dev column and we'll correspond about this in the Pull Request. @scolapasta is reviewing.

@djbrooke djbrooke assigned mdmADA and unassigned scolapasta May 21, 2019
@scolapasta
Copy link
Contributor

@mdmADA Tania and I reviewed the current state of the demo and the UI looks good for a first pass. You mentioned the idea of differentiating between requests, so one straightforward addition would be to add the date as another column. That way the curator should be able to tell if two requests cam in together.

@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2022

Here's the latest PR by @mdmADA related to this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.