Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Files Table: Table Tries to Load More Files, When There Are No More #2701

Closed
kcondon opened this issue Oct 27, 2015 · 2 comments
Closed
Labels
Feature: File Upload & Handling Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@kcondon
Copy link
Contributor

kcondon commented Oct 27, 2015

[Kevin]
My original report was that if there were exactly 25 files, the scroll bar appears and you can scroll back and forth, the spinner runs and seems like it is doing work. Not sure this is very important but wanted to mention it. So for instance there could be logic that if there are exactly 25 files, it does not do the cut off thing, that was my only point.

[Mike]
If a dataset has enough files to go past the "92%" scrollHeight of the files datatable -- the file count setting for the scroller cut-off is 25 files -- it partially displays the last file, shows a scrollbar (in Chrome) and always displays the spinner when you scroll to the bottom of the table because it's trying to load more files, even if there aren't any more files to load.

See Twenty-Five (25, XXV) or Test Wrong File Bug on dataverse-internal.

@kcondon kcondon added UX & UI: Design This issue needs input on the design of the UI and from the product owner Priority: Medium Feature: File Upload & Handling Type: Bug a defect labels Oct 27, 2015
@kcondon kcondon added this to the 4.2.1 Performance patch milestone Oct 27, 2015
@mheppler mheppler changed the title Files Tab: If there are 25 files, the page size for scroller, it partially displays the 25th file, shows scrollbar and always scrolls. Dataset Files Table: Table Tries to Load More Files, When There Are No More Oct 28, 2015
@scolapasta scolapasta modified the milestones: 4.2.1 Performance patch, 4.3 Nov 2, 2015
@mheppler
Copy link
Contributor

mheppler commented Nov 9, 2015

Related to #2731.

Changing the scrolling table to a new PrimeFaces 5 DataScroller component will resolve this issue.

@mercecrosas mercecrosas modified the milestones: 4.3, In Review Nov 30, 2015
@mheppler mheppler removed their assignment Jan 11, 2016
@scolapasta scolapasta modified the milestone: Not Assigned to a Release Jan 28, 2016
@mheppler
Copy link
Contributor

A new issue, Dataset - File UI Improvements #3404, was created to track the UI improvements related to the files view on the dataset pg. Older feature requests and bug reports like this one will be closed in favor of that new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: File Upload & Handling Type: Bug a defect UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

4 participants