Skip to content

Commit 1858bfe

Browse files
committed
Get evnVars['Path'] before calling spawn since it is modified on Windows. nodejs/node#34667.
1 parent 69a2bfd commit 1858bfe

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/components/builder.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,7 @@ export class Builder {
257257
this.extension.manager.setEnvVar()
258258
const envVars: ProcessEnv = {}
259259
Object.keys(process.env).forEach(key => envVars[key] = process.env[key])
260+
const evnVarsPath = envVars['PATH']
260261
const currentEnv = steps[index].env
261262
if (currentEnv) {
262263
Object.keys(currentEnv).forEach(key => envVars[key] = currentEnv[key])
@@ -298,7 +299,7 @@ export class Builder {
298299

299300
this.currentProcess.on('error', err => {
300301
this.extension.logger.addLogMessage(`LaTeX fatal error: ${err.message}, ${stderr}. PID: ${pid}.`)
301-
this.extension.logger.addLogMessage(`Does the executable exist? PATH: ${envVars['PATH']}`)
302+
this.extension.logger.addLogMessage(`Does the executable exist? PATH: ${evnVarsPath}`)
302303
this.extension.logger.addLogMessage(`The environment variable $SHELL: ${process.env.SHELL}`)
303304
this.extension.logger.displayStatus('x', 'errorForeground', `Recipe terminated with fatal error: ${err.message}.`, 'error')
304305
this.currentProcess = undefined
@@ -309,7 +310,7 @@ export class Builder {
309310
this.extension.compilerLogParser.parse(stdout, rootFile)
310311
if (exitCode !== 0) {
311312
this.extension.logger.addLogMessage(`Recipe returns with error: ${exitCode}/${signal}. PID: ${pid}. message: ${stderr}.`)
312-
this.extension.logger.addLogMessage(`The environment variable $PATH: ${envVars['PATH']}`)
313+
this.extension.logger.addLogMessage(`The environment variable $PATH: ${evnVarsPath}`)
313314
this.extension.logger.addLogMessage(`The environment variable $SHELL: ${process.env.SHELL}`)
314315

315316
const configuration = vscode.workspace.getConfiguration('latex-workshop')

0 commit comments

Comments
 (0)