Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of vignette images to reduce package size #786

Closed
JanMarvin opened this issue Sep 2, 2023 · 2 comments
Closed

Removal of vignette images to reduce package size #786

JanMarvin opened this issue Sep 2, 2023 · 2 comments
Labels
documentation ✍️ Improvements or additions to documentation

Comments

@JanMarvin
Copy link
Owner

Similar to the removal of most of the included example and test files, I want to remove the images from the vignettes and point people to https://github.com/JanMarvin/ox2-book for a detailed visual guide.
@JanMarvin JanMarvin added the documentation ✍️ Improvements or additions to documentation label Sep 2, 2023
@olivroy
Copy link
Collaborator

olivroy commented Sep 5, 2023

Hi @JanMarvin, in case you were not aware,

you may want to use articles instead of vignettes

https://r-pkgs.org/website.html#non-vignette-articles

Articles only show on the website, but are not built in the pkg.

Images are valuable in docs imo.

usethis::use_article() to create one.

@olivroy olivroy mentioned this issue Sep 6, 2023
Closed
@JanMarvin
Copy link
Owner Author

Closed in #1106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation ✍️ Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JanMarvin @olivroy