Skip to content

Commit 4873ae7

Browse files
committed
JBR-8189 revert "8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected."
This reverts commit 488baa5.
1 parent 325a55a commit 4873ae7

File tree

3 files changed

+2
-39
lines changed

3 files changed

+2
-39
lines changed

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java

-31
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
import java.awt.Window;
4646
import java.awt.event.FocusEvent;
4747
import java.awt.event.WindowEvent;
48-
import java.awt.event.WindowStateListener;
4948
import java.awt.peer.ComponentPeer;
5049
import java.beans.PropertyChangeEvent;
5150
import java.beans.PropertyChangeListener;
@@ -1067,33 +1066,6 @@ public boolean isFullScreenMode() {
10671066
return isFullScreenMode;
10681067
}
10691068

1070-
private void waitForWindowState(int state) {
1071-
if (peer.getState() == state) {
1072-
return;
1073-
}
1074-
1075-
Object lock = new Object();
1076-
WindowStateListener wsl = new WindowStateListener() {
1077-
public void windowStateChanged(WindowEvent e) {
1078-
synchronized (lock) {
1079-
if (e.getNewState() == state) {
1080-
lock.notifyAll();
1081-
}
1082-
}
1083-
}
1084-
};
1085-
1086-
target.addWindowStateListener(wsl);
1087-
if (peer.getState() != state) {
1088-
synchronized (lock) {
1089-
try {
1090-
lock.wait();
1091-
} catch (InterruptedException ie) {}
1092-
}
1093-
}
1094-
target.removeWindowStateListener(wsl);
1095-
}
1096-
10971069
@Override
10981070
public void setWindowState(int windowState) {
10991071
if (peer == null || !peer.isVisible()) {
@@ -1115,16 +1087,13 @@ public void setWindowState(int windowState) {
11151087
// let's return into the normal states first
11161088
// the zoom call toggles between the normal and the max states
11171089
unmaximize();
1118-
waitForWindowState(Frame.NORMAL);
11191090
}
11201091
execute(CWrapper.NSWindow::miniaturize);
11211092
break;
11221093
case Frame.MAXIMIZED_BOTH:
11231094
if (prevWindowState == Frame.ICONIFIED) {
11241095
// let's return into the normal states first
11251096
execute(CWrapper.NSWindow::deminiaturize);
1126-
waitForWindowState(Frame.NORMAL);
1127-
11281097
}
11291098
maximize();
11301099
break;

test/jdk/ProblemList.txt

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java 8081489 generi
119119
java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java 6849364 generic-all
120120
java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java 6848406 generic-all
121121
java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java 6848407 generic-all
122+
java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java 8296972 macosx-all
122123
java/awt/Frame/MaximizedUndecorated/MaximizedUndecorated.java 8022302 generic-all
123124
java/awt/Frame/RestoreToOppositeScreen/RestoreToOppositeScreen.java 8286840 linux-all
124125
java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java 8160558 windows-all

test/jdk/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

+1-8
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545

4646
public class MaximizedToIconified
4747
{
48-
static volatile int lastFrameState;
48+
static volatile int lastFrameState = Frame.NORMAL;
4949
static volatile boolean failed = false;
5050
static volatile Toolkit myKit;
5151
private static Robot robot;
@@ -77,8 +77,6 @@ private static void examineStates(int states[]) {
7777
frame.setSize(200, 200);
7878
frame.setVisible(true);
7979

80-
lastFrameState = Frame.NORMAL;
81-
8280
robot.waitForIdle();
8381

8482
frame.addWindowStateListener(new WindowStateListener() {
@@ -116,12 +114,7 @@ private static void doTest() {
116114
// because Toolkit.isFrameStateSupported() method reports these states
117115
// as not supported. And such states will simply be skipped.
118116
examineStates(new int[] {Frame.MAXIMIZED_BOTH, Frame.ICONIFIED, Frame.NORMAL});
119-
System.out.println("------");
120117
examineStates(new int[] {Frame.ICONIFIED, Frame.MAXIMIZED_BOTH, Frame.NORMAL});
121-
System.out.println("------");
122-
examineStates(new int[] {Frame.NORMAL, Frame.MAXIMIZED_BOTH, Frame.ICONIFIED});
123-
System.out.println("------");
124-
examineStates(new int[] {Frame.NORMAL, Frame.ICONIFIED, Frame.MAXIMIZED_BOTH});
125118

126119
}
127120

0 commit comments

Comments
 (0)