Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetPlaylistTracksAsync without userId deprecated #422

Closed
jakoss opened this issue Mar 3, 2020 · 1 comment · Fixed by #423
Closed

GetPlaylistTracksAsync without userId deprecated #422

jakoss opened this issue Mar 3, 2020 · 1 comment · Fixed by #423
Labels

Comments

@jakoss
Copy link
Contributor

jakoss commented Mar 3, 2020

In code this method is marked as obsolete with warning "Calling GetPlaylistTracks with a userId is deprecated, remove the parameter". But there is no userId here. And there is no GetPlaylistTracksAsync overload that is not obsolete. I believe this is a mistake?

public Task<Paging<PlaylistTrack>> GetPlaylistTracksAsync(string playlistId, string fields = "", int limit = 100, int offset = 0, string market = "")
@JohnnyCrazy
Copy link
Owner

Indeed, that's an issue

The following should not be marked obsolote:

[Obsolete("Calling GetPlaylistTracks with a userId is deprecated, remove the parameter")]
public Task<Paging<PlaylistTrack>> GetPlaylistTracksAsync(string playlistId, string fields = "", int limit = 100, int offset = 0, string market = "")

Feel free to submit a PR, or I will do it this evening :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants