Skip to content

Commit 8726cf5

Browse files
committed
Accommodate more than 1 page of comments / commits
1 parent 75b0730 commit 8726cf5

File tree

1 file changed

+21
-10
lines changed

1 file changed

+21
-10
lines changed

scripts/utils/prs.js

+21-10
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,17 @@ const prHelpers = robot => {
111111
}
112112

113113
const getComments = async pr => {
114-
return new Promise(resolve => {
115-
github.get(`${pr.issue_url}/comments`, res => {
116-
resolve(res)
117-
})
118-
})
114+
const comments = []
115+
let nOnPage = 30
116+
let page = 1
117+
while (nOnPage === 30) {
118+
const res = await ghget(`${pr.url}/comments?per_page=${nOnPage}&page=${page}`)
119+
nOnPage = res.length
120+
page +=1
121+
comments.push(...res)
122+
}
123+
return comments
124+
119125
}
120126

121127
const isReviewOld = (reviewRequestedTimeStamp, threshold) => {
@@ -171,11 +177,16 @@ const prHelpers = robot => {
171177
}
172178

173179
const getPRCommits = async pr => {
174-
return new Promise(resolve => {
175-
github.get(`${pr.url}/commits`, res => {
176-
resolve(res)
177-
})
178-
})
180+
const commits = []
181+
let nOnPage = 30
182+
let page = 1
183+
while (nOnPage === 30) {
184+
const res = await ghget(`${pr.url}/commits?per_page=${nOnPage}&page=${page}`)
185+
nOnPage = res.length
186+
page +=1
187+
commits.push(...res)
188+
}
189+
return commits
179190
}
180191

181192
return {

0 commit comments

Comments
 (0)