Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping on GO.touches(p1, p2) #117

Open
asinghvi17 opened this issue Apr 21, 2024 · 1 comment
Open

Clipping on GO.touches(p1, p2) #117

asinghvi17 opened this issue Apr 21, 2024 · 1 comment
Labels
clipping About polygon clipping or processing discussion

Comments

@asinghvi17
Copy link
Member

Consider 2 polygons for which GO.touches(p1, p2) == true. In this case, the intersection is generally understood to be a linestring.

Two questions arise:
(a) GeometryOps currently returns an empty polygon for intersect(p1, p2). Should we allow it to return a LineString if the target is set to GeometryCollection? If so, how would that work with the current Foster algorithm?
(b) Do we need to check intersection dimensionality first before constructing the intersection?

@asinghvi17 asinghvi17 added discussion clipping About polygon clipping or processing labels Apr 21, 2024
@asinghvi17
Copy link
Member Author

This could be solved if we implement the JTS OverlayNG methods which are specifically for these kinds of cases. But they're a bit slower than Foster, so we need to watch out for that. Offering OverlayNG as an algorithm is definitely an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clipping About polygon clipping or processing discussion
Projects
None yet
Development

No branches or pull requests

1 participant