Skip to content

Commit 8656519

Browse files
authored
Merge pull request #195 from JuliaIO/an/info
Don't try to extend Base.info
2 parents b69bbab + 369d792 commit 8656519

File tree

3 files changed

+29
-26
lines changed

3 files changed

+29
-26
lines changed

appveyor.yml

+24-21
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,36 @@
11
environment:
22
matrix:
3-
- JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x86/0.7/julia-0.7-latest-win32.exe"
4-
- JULIA_URL: "https://julialang-s3.julialang.org/bin/winnt/x64/0.7/julia-0.7-latest-win64.exe"
5-
- JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x86/julia-latest-win32.exe"
6-
- JULIA_URL: "https://julialangnightlies-s3.julialang.org/bin/winnt/x64/julia-latest-win64.exe"
3+
- julia_version: 0.7
4+
- julia_version: latest
5+
6+
platform:
7+
- x86 # 32-bit
8+
- x64 # 64-bit
9+
10+
## uncomment the following lines to allow failures on nightly julia
11+
## (tests will run but not make your overall status red)
12+
#matrix:
13+
# allow_failures:
14+
# - julia_version: latest
715

816
branches:
917
only:
1018
- master
1119
- /release-.*/
20+
21+
notifications:
22+
- provider: Email
23+
on_build_success: false
24+
on_build_failure: false
25+
on_build_status_changed: false
26+
1227
install:
13-
- ps: "[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12"
14-
# if there's a newer build queued for the same PR, cancel this one
15-
- ps: if ($env:APPVEYOR_PULL_REQUEST_NUMBER -and $env:APPVEYOR_BUILD_NUMBER -ne ((Invoke-RestMethod `
16-
https://ci.appveyor.com/api/projects/$env:APPVEYOR_ACCOUNT_NAME/$env:APPVEYOR_PROJECT_SLUG/history?recordsNumber=50).builds | `
17-
Where-Object pullRequestId -eq $env:APPVEYOR_PULL_REQUEST_NUMBER)[0].buildNumber) { `
18-
throw "There are newer queued builds for this pull request, failing early." }
19-
# Download most recent Julia Windows binary
20-
- ps: (new-object net.webclient).DownloadFile(
21-
$env:JULIA_URL,
22-
"C:\projects\julia-binary.exe")
23-
# Run installer silently, output to C:\projects\julia
24-
- C:\projects\julia-binary.exe /S /D=C:\projects\julia
28+
- ps: iex ((new-object net.webclient).DownloadString("https://raw.githubusercontent.com/JuliaCI/Appveyor.jl/version-1/bin/install.ps1"))
2529

2630
build_script:
27-
# Need to convert from shallow to complete for Pkg.clone to work
28-
# - git fetch --unshallow
29-
- C:\projects\julia\bin\julia -e "using InteractiveUtils; versioninfo(); import Pkg;
30-
Pkg.clone(pwd(), \"FileIO\"); Pkg.build(\"FileIO\")"
31+
- echo "%JL_BUILD_SCRIPT%"
32+
- C:\julia\bin\julia -e "%JL_BUILD_SCRIPT%"
3133

3234
test_script:
33-
- C:\projects\julia\bin\julia -e "import Pkg; Pkg.test(\"FileIO\")"
35+
- echo "%JL_TEST_SCRIPT%"
36+
- C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"

src/query.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ end
159159
`info(fmt)` returns the magic bytes/extension information for
160160
`DataFormat` `fmt`.
161161
"""
162-
Base.info(::Type{DataFormat{sym}}) where {sym} = sym2info[sym]
162+
info(::Type{DataFormat{sym}}) where {sym} = sym2info[sym]
163163

164164

165165
canonicalize_magic(m::NTuple{N,UInt8}) where {N} = m

test/query.jl

+4-4
Original file line numberDiff line numberDiff line change
@@ -67,21 +67,21 @@ try
6767
@test unknown(format"UNKNOWN")
6868

6969
add_format(format"CSV", UInt8[], ".csv")
70-
@test info(format"CSV") == ((),".csv")
70+
@test FileIO.info(format"CSV") == ((),".csv")
7171
add_format(format"FOO", (), ".foo") # issue #17
72-
@test_throws Exception info(format"OOPS")
72+
@test_throws Exception FileIO.info(format"OOPS")
7373
@test FileIO.ext2sym[".csv"] == :CSV
7474
del_format(format"FOO")
7575
@test FileIO.magic_list == [Pair((),:CSV)]
7676
del_format(format"CSV")
7777
@test isempty(FileIO.ext2sym)
7878
@test isempty(FileIO.magic_list)
7979
@test isempty(FileIO.sym2info)
80-
@test_throws Exception info(format"CSV")
80+
@test_throws Exception FileIO.info(format"CSV")
8181

8282
add_format(format"JUNK", "JUNK", [".jnk",".junk",".JNK"])
8383

84-
@test info(format"JUNK") == (tuple(b"JUNK"...),[".jnk",".junk",".JNK"])
84+
@test FileIO.info(format"JUNK") == (tuple(b"JUNK"...),[".jnk",".junk",".JNK"])
8585
@test FileIO.ext2sym[".jnk"] == :JUNK
8686
@test FileIO.ext2sym[".junk"] == :JUNK
8787
@test FileIO.ext2sym[".JNK"] == :JUNK

0 commit comments

Comments
 (0)