Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding configuration support with -c / --config argument #21

Closed
3 tasks done
irenejoeunpark opened this issue Oct 6, 2021 · 2 comments
Closed
3 tasks done

Adding configuration support with -c / --config argument #21

irenejoeunpark opened this issue Oct 6, 2021 · 2 comments
Assignees
@irenejoeunpark
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@irenejoeunpark
Copy link
Contributor

irenejoeunpark commented Oct 6, 2021 •
edited
Loading

Hi @Kevan-Y,

I would like to add configuration support to your project to pass a JSON file path that has the configuration to edit the project.

TODO :

  • Add -c and --config argument to the project to accept JSON file path for its configuration
  • Ignore any unsupported file types or properties
  • Update Readme
@Kevan-Y Kevan-Y added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 7, 2021
This was referenced Oct 13, 2021
Closed
Merged
@irenejoeunpark
Copy link
Contributor Author

Feature branch merged

@Kevan-Y
Copy link
Owner

Kevan-Y commented Oct 13, 2021

Feature branch merged

Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irenejoeunpark irenejoeunpark

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irenejoeunpark @Kevan-Y