Skip to content

Commit 5aae548

Browse files
authored
Merge pull request #320 from LDSSA/feature/card#319
Modify column Name content from username to first_name + last_name. A…
2 parents ca497e8 + cb1821e commit 5aae548

File tree

5 files changed

+7
-9
lines changed

5 files changed

+7
-9
lines changed

__init__.py

Whitespace-only changes.

portal/__init__.py

Whitespace-only changes.

portal/portal/__init__.py

-7
This file was deleted.

portal/portal/academy/views.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ class StudentUnitDetailView(StudentViewsMixin, BaseUnitDetailView):
140140

141141
class InstructorUserListView(InstructorViewsMixin, ListView):
142142
model = get_user_model()
143-
queryset = get_user_model().objects.filter(is_student=True, failed_or_dropped=False)
143+
queryset = model.objects.filter(is_student=True, failed_or_dropped=False)
144+
#queryset = get_user_model().objects.filter(is_student=True, failed_or_dropped=False)
144145
template_name = "academy/instructor/user_list.html"
145146

146147
def get_queryset(self):

portal/portal/templates/academy/instructor/user_list.html

+5-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ <h1><a href="{% url 'academy:instructor-user-list' %}" class="text-dark" title="
1818
<thead>
1919
<tr>
2020
<th scope="col" rowspan="2">Name</th>
21+
{% comment %}
2122
<th scope="col" rowspan="2">Slack</th>
23+
{% endcomment %}
2224
<th scope="col" rowspan="2">Submission Date</th>
2325
<th scope="col" rowspan="2">Total</th>
2426
<th scope="col" rowspan="2">Eligible for graduation</th>
@@ -37,8 +39,10 @@ <h1><a href="{% url 'academy:instructor-user-list' %}" class="text-dark" title="
3739
<tbody>
3840
{% for obj in object_list %}
3941
<tr>
40-
<th><a href="{% add_query_param 'user_id' obj.user.id %}" class="text-dark" title="Filter by student">{{ obj.user.username }}</a></th>
42+
<th><a href="{% add_query_param 'user_id' obj.user.id %}" class="text-dark" title="Filter by student">{{ obj.user.first_name }} {{ obj.user.last_name }}</a></th>
43+
{% comment %}
4144
<td><a href="{{ workspace_url }}{{ obj.user.slack_member_id }}" target="_blank" class="text-dark">{{ obj.user.slack_member_id }}</a></td>
45+
{% endcomment %}
4246
<td><a href="{% add_query_param 'submission_date' obj.submission_date %}" class="text-dark"> {{ obj.submission_date }} </a></td>
4347
<td><a href="{% add_query_param 'score__gte' obj.total_score %}" class="text-dark">{{ obj.total_score }}&#47;{{ max_score }}</a></td>
4448
<th><a href="{% add_query_param 'can_graduate' obj.user.can_graduate %}" class="text-dark" title="Filter by graduation status">{% if obj.user.can_graduate %}Yes{% else %}No{% endif %}</a></th>

0 commit comments

Comments
 (0)