Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic theming + dark theme #398

Open
1 of 2 tasks
headquarter8302 opened this issue Mar 20, 2025 · 3 comments
Open
1 of 2 tasks

Dynamic theming + dark theme #398

headquarter8302 opened this issue Mar 20, 2025 · 3 comments

Comments

@headquarter8302
Copy link
Contributor

headquarter8302 commented Mar 20, 2025

I've been given the greenlight on the Discord by @tresf to start working on a dark theme with an added feature of automatic system theme detection.

This issue ticket will be used to track progress, discuss changes, also so that the PR wouldn't dangle without an attached issue.

To-do

  • Implement the dark theme completely in CSS/SCSS. Without doing additional changes to server logic or scripting
  • Implement a theme toggle, probably in the navbar since it's sticky

Changes

  • Darkened jumbotron's green tint
  • Apply LMMS's dark tint to every background/neutral surface
  • Buttons on the download page
  • Made all theme changes responsive to the user's preferred color scheme. This can be observed by using the Rendering tab's "Emulate CSS media feature prefers-color-scheme" in your browser's Devtool

Pages done

  • index
    • index
  • download
    • download
  • get-involved
    • get-involved
  • showcase
    • showcase
  • branding
    • Image
  • lsp
    • lsp-index
    • lsp-post

Difficulties

  1. I've been unable to properly make styles for LSP, since it wouldn't build the database. Nor am I confident that an empty DB would produce all the possible layouts and elements for the styling. This is a blocker before the PR can be merged I've found a way to style LSP without building
  2. It is a pain in the ass to set this up on Windows. I am definitely going to make build steps for Windows after this
@tresf
Copy link
Member

tresf commented Mar 20, 2025

This is awesome! I might be able to set you up with a skeleton copy of the LSP database. You can give yourself admin and upload a few things for testing.

@headquarter8302
Copy link
Contributor Author

I've added LSP screenshots

@tresf
Copy link
Member

tresf commented Mar 20, 2025

#399 is merged, but I'm leaving this open incase you want to still work on this task:

  • Implement a theme toggle, probably in the navbar since it's sticky

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants