Skip to content

Commit

Permalink
Breaking: drop Node.js < 16 and Electron < 18
Browse files Browse the repository at this point in the history
Category: removal
  • Loading branch information
vweevers committed Oct 20, 2024
1 parent d5bad80 commit c177f3c
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 7 deletions.
4 changes: 4 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ updates:
- dependency-name: node-gyp
# ESM-only
- dependency-name: tempy

# Stay on the 3rd or 4th oldest stable release, per
# https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy
- dependency-name: electron
- package-ecosystem: github-actions
directory: /
schedule:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
architecture: ${{ matrix.arch }}
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Set up node
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
architecture: ${{ matrix.arch }}
# Temporary fix for https://github.com/nodejs/node-gyp/issues/2869
# TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
matrix:
# At the time of writing macos-latest is mac 10; we need 11 to build a universal binary.
os: [ubuntu-latest, macos-11, windows-latest]
node: [12, 14, 16]
node: [16, 18, 20]
arch: [x86, x64]
exclude:
- { os: ubuntu-latest, arch: x86 }
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:
with:
file: coverage/lcov.info
- name: Test Electron
if: ${{ matrix.node == '14' }}
if: ${{ matrix.node == '16' }}
uses: GabrielBB/xvfb-action@v1
with:
run: npm run test-electron
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const xyz = db.sublevel<string, any>('xyz', { valueEncoding: 'json' })

## Supported Platforms

We aim to support _at least_ Active LTS and Current Node.js releases, Electron 5.0.0, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).
We aim to support _at least_ Active LTS and Current Node.js releases, Electron >= 18, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html).

The `classic-level` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android, Alpine (musl), Windows 32-bit, Linux flavors with an old glibc (Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7) and is known to work on:

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"cross-env": "^7.0.3",
"dependency-check": "^4.1.0",
"du": "^1.0.0",
"electron": "^21.0.1",
"electron": "^18.3.15",
"glob": "^8.0.1",
"hallmark": "^4.1.0",
"mkfiletree": "^2.0.0",
Expand Down Expand Up @@ -66,6 +66,6 @@
"level"
],
"engines": {
"node": ">=12"
"node": ">=16"
}
}

0 comments on commit c177f3c

Please sign in to comment.