From c177f3cd2b5820564d2eb6d563df3e1304f8d758 Mon Sep 17 00:00:00 2001 From: Vincent Weevers Date: Fri, 18 Nov 2022 14:58:38 +0100 Subject: [PATCH] Breaking: drop Node.js < 16 and Electron < 18 Category: removal --- .github/dependabot.yml | 4 ++++ .github/workflows/release.yml | 2 +- .github/workflows/smoke.yml | 2 +- .github/workflows/test.yml | 4 ++-- README.md | 2 +- package.json | 4 ++-- 6 files changed, 11 insertions(+), 7 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 6f71068..24e1f78 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -10,6 +10,10 @@ updates: - dependency-name: node-gyp # ESM-only - dependency-name: tempy + + # Stay on the 3rd or 4th oldest stable release, per + # https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy + - dependency-name: electron - package-ecosystem: github-actions directory: / schedule: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 1801772..af3f951 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -40,7 +40,7 @@ jobs: - name: Set up node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 16 architecture: ${{ matrix.arch }} # Temporary fix for https://github.com/nodejs/node-gyp/issues/2869 # TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14) diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 7e3ed71..2755d2b 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -41,7 +41,7 @@ jobs: - name: Set up node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 16 architecture: ${{ matrix.arch }} # Temporary fix for https://github.com/nodejs/node-gyp/issues/2869 # TODO: instead bump node-gyp to >= 10.0.0 (drops Node.js < 16.14) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a001810..8493a0e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: matrix: # At the time of writing macos-latest is mac 10; we need 11 to build a universal binary. os: [ubuntu-latest, macos-11, windows-latest] - node: [12, 14, 16] + node: [16, 18, 20] arch: [x86, x64] exclude: - { os: ubuntu-latest, arch: x86 } @@ -42,7 +42,7 @@ jobs: with: file: coverage/lcov.info - name: Test Electron - if: ${{ matrix.node == '14' }} + if: ${{ matrix.node == '16' }} uses: GabrielBB/xvfb-action@v1 with: run: npm run test-electron diff --git a/README.md b/README.md index 3221bd6..668eb49 100644 --- a/README.md +++ b/README.md @@ -142,7 +142,7 @@ const xyz = db.sublevel('xyz', { valueEncoding: 'json' }) ## Supported Platforms -We aim to support _at least_ Active LTS and Current Node.js releases, Electron 5.0.0, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html). +We aim to support _at least_ Active LTS and Current Node.js releases, Electron >= 18, as well as any future Node.js and Electron releases thanks to [Node-API](https://nodejs.org/api/n-api.html). The `classic-level` npm package ships with prebuilt binaries for popular 64-bit platforms as well as ARM, M1, Android, Alpine (musl), Windows 32-bit, Linux flavors with an old glibc (Debian 8, Ubuntu 14.04, RHEL 7, CentOS 7) and is known to work on: diff --git a/package.json b/package.json index 96766c0..e609682 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "cross-env": "^7.0.3", "dependency-check": "^4.1.0", "du": "^1.0.0", - "electron": "^21.0.1", + "electron": "^18.3.15", "glob": "^8.0.1", "hallmark": "^4.1.0", "mkfiletree": "^2.0.0", @@ -66,6 +66,6 @@ "level" ], "engines": { - "node": ">=12" + "node": ">=16" } }