DatePicker and DateTimePicker UseFloatingWatermark don't work

[AndrzejKl]

What steps will reproduce this issue?

<DatePicker  Controls:TextBoxHelper.UseFloatingWatermark="True"
             Controls:TextBoxHelper.Watermark="Watermark:"  />

If SelectedDate is null, then Watermark is visible, but FloatingWatermark don't work when SelectedDate != null.

Expected outcome

Should work like on others controls

Environment

• MahApps.Metro v1.3.0.155
• Windows 10
• Visual Studio 2013 & 2015
• .NET Framework 4.5

[punker76]

@AndrzejKl yeah, UseFloatingWatermark not implemented yet for DatePicker...

[michaelmairegger]

@punker76 are you already developing this feature? Otherwise I could do that for DateTimePicker and for TimePicker too.

[punker76]

@xxMUROxx you can do it for DateTimePicker and for TimePicker, I'm currently on the Flyout PR

[AndrzejKl]

@xxMUROxx and for DatePicker ;)

[AndrzejKl]

@punker76 @xxMUROxx
in prerelase Alpha 162 it should work?
If yes, still are some problems:

1. Datepicker in grid works somehow, but height doesn't get smaller, when You delete selectedDate:
   Before selecting date:
   
   After selecting:
   
   After deleting date:
   
   The same is for DateTimePicker, but at least Watermark vertically centering.
   For TextBox it works fine.
2. Problems start when You add DatePicker or DateTimePicker to StackPanel. Window start to increase and it doesn't stop. Just add that code and select date from calendar.

<Controls:MetroWindow x:Class="wpf_test.MainWindow"
                      xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                      xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                      xmlns:Controls="http://metro.mahapps.com/winfx/xaml/controls"
                      xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
                      xmlns:local="clr-namespace:wpf_test"
                      xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
                      Title="MainWindow"
                      GlowBrush="{DynamicResource AccentColorBrush}"
                      SizeToContent="WidthAndHeight"
                      mc:Ignorable="d">
    <StackPanel>
        <DatePicker Controls:TextBoxHelper.UseFloatingWatermark="True"
                    Controls:TextBoxHelper.Watermark="Watermark"
                    SelectedDateFormat="Long" />
    </StackPanel>
</Controls:MetroWindow>

[punker76]

@AndrzejKl should work after 6a954d1 MahApps.Metro 1.3.0-ALPHA163

[AndrzejKl]

@punker76 @xxMUROxx Thanks, it looks that it works (Alpha 165)

BTW: Maybe it will be possible to add for DatePicker, DateTimePicker and TimePicker "IsWaitingForData" functionality? R should I open new issue?

[punker76]

@AndrzejKl Good! But I must say, that I don't like the IsWaitingForData effect stuff. IsWaitingForData for itself is good, but the effect has nasty effects 😭 if you use it with floating watermarks.

[AndrzejKl]

@punker76 You mean visual effects or technical ones? IMO Visually it looks fine (with floating watermark)...