Skip to content

Commit 21a6044

Browse files
committed
🚸 Move solo Case Light menu up
1 parent deb076b commit 21a6044

File tree

2 files changed

+30
-21
lines changed

2 files changed

+30
-21
lines changed

Marlin/src/lcd/menu/menu_led.cpp

+20-19
Original file line numberDiff line numberDiff line change
@@ -111,24 +111,24 @@
111111
#if ENABLED(CASE_LIGHT_MENU)
112112
#include "../../feature/caselight.h"
113113

114-
#define CASELIGHT_TOGGLE_ITEM() EDIT_ITEM(bool, MSG_CASE_LIGHT, (bool*)&caselight.on, caselight.update_enabled)
115114

116115
#if CASELIGHT_USES_BRIGHTNESS
117116
void menu_case_light() {
118117
START_MENU();
119118
BACK_ITEM(MSG_CONFIGURATION);
120119
EDIT_ITEM(percent, MSG_CASE_LIGHT_BRIGHTNESS, &caselight.brightness, 0, 255, caselight.update_brightness, true);
121-
CASELIGHT_TOGGLE_ITEM();
120+
EDIT_ITEM(bool, MSG_CASE_LIGHT, &caselight.on, caselight.update_enabled);
122121
END_MENU();
123122
}
124123
#endif
125124
#endif
126125

127-
void menu_led() {
128-
START_MENU();
129-
BACK_ITEM(MSG_MAIN_MENU);
126+
#if ENABLED(LED_CONTROL_MENU)
127+
128+
void menu_led() {
129+
START_MENU();
130+
BACK_ITEM(MSG_MAIN_MENU);
130131

131-
#if ENABLED(LED_CONTROL_MENU)
132132
if (TERN1(PSU_CONTROL, powerManager.psu_on)) {
133133
editable.state = leds.lights_on;
134134
EDIT_ITEM(bool, MSG_LEDS, &editable.state, leds.toggle);
@@ -152,21 +152,22 @@ void menu_led() {
152152
SUBMENU(MSG_NEO2_PRESETS, menu_leds2_presets);
153153
#endif
154154
SUBMENU(MSG_CUSTOM_LEDS, menu_led_custom);
155-
#endif
156155

157-
//
158-
// Set Case light on/off/brightness
159-
//
160-
#if ENABLED(CASE_LIGHT_MENU)
161-
#if CASELIGHT_USES_BRIGHTNESS
162-
if (caselight.has_brightness())
163-
SUBMENU(MSG_CASE_LIGHT, menu_case_light);
164-
else
156+
//
157+
// Set Case light on/off/brightness
158+
//
159+
#if ENABLED(CASE_LIGHT_MENU)
160+
#if CASELIGHT_USES_BRIGHTNESS
161+
if (caselight.has_brightness())
162+
SUBMENU(MSG_CASE_LIGHT, menu_case_light);
163+
else
164+
#endif
165+
EDIT_ITEM(bool, MSG_CASE_LIGHT, &caselight.on, caselight.update_enabled);
165166
#endif
166-
CASELIGHT_TOGGLE_ITEM();
167-
#endif
168167

169-
END_MENU();
170-
}
168+
END_MENU();
169+
}
170+
171+
#endif // LED_CONTROL_MENU
171172

172173
#endif // HAS_MARLINUI_MENU && LED_CONTROL_MENU

Marlin/src/lcd/menu/menu_main.cpp

+10-2
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,12 @@ void menu_configuration();
8888
void menu_info();
8989
#endif
9090

91-
#if ANY(LED_CONTROL_MENU, CASE_LIGHT_MENU)
91+
#if ENABLED(LED_CONTROL_MENU)
9292
void menu_led();
93+
#elif ALL(CASE_LIGHT_MENU, CASELIGHT_USES_BRIGHTNESS)
94+
void menu_case_light();
95+
#elif ENABLED(CASE_LIGHT_MENU)
96+
#include "../../feature/caselight.h"
9397
#endif
9498

9599
#if HAS_CUTTER
@@ -371,8 +375,12 @@ void menu_main() {
371375
SUBMENU(MSG_INFO_MENU, menu_info);
372376
#endif
373377

374-
#if ANY(LED_CONTROL_MENU, CASE_LIGHT_MENU)
378+
#if ENABLED(LED_CONTROL_MENU)
375379
SUBMENU(MSG_LEDS, menu_led);
380+
#elif ALL(CASE_LIGHT_MENU, CASELIGHT_USES_BRIGHTNESS)
381+
SUBMENU(MSG_CASE_LIGHT, menu_case_light);
382+
#elif ENABLED(CASE_LIGHT_MENU)
383+
EDIT_ITEM(bool, MSG_CASE_LIGHT, &caselight.on, caselight.update_enabled);
376384
#endif
377385

378386
//

0 commit comments

Comments
 (0)