Skip to content

Commit 89ccede

Browse files
filimonicthinkyhead
andauthoredApr 22, 2023
🎨 Clean up TFT Color UI display items (#25712)
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
1 parent fba1f83 commit 89ccede

File tree

4 files changed

+33
-50
lines changed

4 files changed

+33
-50
lines changed
 

‎Marlin/src/lcd/tft/ui_1024x600.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -228,25 +228,25 @@ void MarlinUI::draw_status_screen() {
228228
for (i = 0 ; i < ITEMS_COUNT; i++) {
229229
x = (TFT_WIDTH / ITEMS_COUNT - 80) / 2 + (TFT_WIDTH * i / ITEMS_COUNT);
230230
switch (i) {
231-
#ifdef ITEM_E0
231+
#if HAS_EXTRUDERS
232232
case ITEM_E0: draw_heater_status(x, y, H_E0); break;
233233
#endif
234-
#ifdef ITEM_E1
234+
#if HAS_MULTI_HOTEND
235235
case ITEM_E1: draw_heater_status(x, y, H_E1); break;
236236
#endif
237-
#ifdef ITEM_E2
237+
#if HOTENDS > 2
238238
case ITEM_E2: draw_heater_status(x, y, H_E2); break;
239239
#endif
240-
#ifdef ITEM_BED
240+
#if HAS_HEATED_BED
241241
case ITEM_BED: draw_heater_status(x, y, H_BED); break;
242242
#endif
243-
#ifdef ITEM_CHAMBER
243+
#if HAS_TEMP_CHAMBER
244244
case ITEM_CHAMBER: draw_heater_status(x, y, H_CHAMBER); break;
245245
#endif
246-
#ifdef ITEM_COOLER
246+
#if HAS_TEMP_COOLER
247247
case ITEM_COOLER: draw_heater_status(x, y, H_COOLER); break;
248248
#endif
249-
#ifdef ITEM_FAN
249+
#if HAS_FAN
250250
case ITEM_FAN: draw_fan_status(x, y, blink); break;
251251
#endif
252252
}

‎Marlin/src/lcd/tft/ui_320x240.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -230,25 +230,25 @@ void MarlinUI::draw_status_screen() {
230230
for (i = 0 ; i < ITEMS_COUNT; i++) {
231231
x = (TFT_WIDTH / ITEMS_COUNT - 64) / 2 + (TFT_WIDTH * i / ITEMS_COUNT);
232232
switch (i) {
233-
#ifdef ITEM_E0
233+
#if HAS_EXTRUDERS
234234
case ITEM_E0: draw_heater_status(x, y, H_E0); break;
235235
#endif
236-
#ifdef ITEM_E1
236+
#if HAS_MULTI_HOTEND
237237
case ITEM_E1: draw_heater_status(x, y, H_E1); break;
238238
#endif
239-
#ifdef ITEM_E2
239+
#if HOTENDS > 2
240240
case ITEM_E2: draw_heater_status(x, y, H_E2); break;
241241
#endif
242-
#ifdef ITEM_BED
242+
#if HAS_HEATED_BED
243243
case ITEM_BED: draw_heater_status(x, y, H_BED); break;
244244
#endif
245-
#ifdef ITEM_CHAMBER
245+
#if HAS_TEMP_CHAMBER
246246
case ITEM_CHAMBER: draw_heater_status(x, y, H_CHAMBER); break;
247247
#endif
248-
#ifdef ITEM_COOLER
248+
#if HAS_TEMP_COOLER
249249
case ITEM_COOLER: draw_heater_status(x, y, H_COOLER); break;
250250
#endif
251-
#ifdef ITEM_FAN
251+
#if HAS_FAN
252252
case ITEM_FAN: draw_fan_status(x, y, blink); break;
253253
#endif
254254
}

‎Marlin/src/lcd/tft/ui_480x320.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -228,25 +228,25 @@ void MarlinUI::draw_status_screen() {
228228
for (i = 0 ; i < ITEMS_COUNT; i++) {
229229
x = (TFT_WIDTH / ITEMS_COUNT - 80) / 2 + (TFT_WIDTH * i / ITEMS_COUNT);
230230
switch (i) {
231-
#ifdef ITEM_E0
231+
#if HAS_EXTRUDERS
232232
case ITEM_E0: draw_heater_status(x, y, H_E0); break;
233233
#endif
234-
#ifdef ITEM_E1
234+
#if HAS_MULTI_HOTEND
235235
case ITEM_E1: draw_heater_status(x, y, H_E1); break;
236236
#endif
237-
#ifdef ITEM_E2
237+
#if HOTENDS > 2
238238
case ITEM_E2: draw_heater_status(x, y, H_E2); break;
239239
#endif
240-
#ifdef ITEM_BED
240+
#if HAS_HEATED_BED
241241
case ITEM_BED: draw_heater_status(x, y, H_BED); break;
242242
#endif
243-
#ifdef ITEM_CHAMBER
243+
#if HAS_TEMP_CHAMBER
244244
case ITEM_CHAMBER: draw_heater_status(x, y, H_CHAMBER); break;
245245
#endif
246-
#ifdef ITEM_COOLER
246+
#if HAS_TEMP_COOLER
247247
case ITEM_COOLER: draw_heater_status(x, y, H_COOLER); break;
248248
#endif
249-
#ifdef ITEM_FAN
249+
#if HAS_FAN
250250
case ITEM_FAN: draw_fan_status(x, y, blink); break;
251251
#endif
252252
}

‎Marlin/src/lcd/tft/ui_common.h

+12-29
Original file line numberDiff line numberDiff line change
@@ -57,32 +57,15 @@ void menu_item(const uint8_t row, bool sel = false);
5757

5858
#define ABSOLUTE_ZERO -273.15
5959

60-
#if HAS_TEMP_CHAMBER && HAS_MULTI_HOTEND
61-
#define ITEM_E0 0
62-
#define ITEM_E1 1
63-
#define ITEM_BED 2
64-
#define ITEM_CHAMBER 3
65-
#define ITEM_FAN 4
66-
#define ITEMS_COUNT 5
67-
#elif HAS_TEMP_CHAMBER
68-
#define ITEM_E0 0
69-
#define ITEM_BED 1
70-
#define ITEM_CHAMBER 2
71-
#define ITEM_FAN 3
72-
#define ITEMS_COUNT 4
73-
#elif HAS_TEMP_COOLER
74-
#define ITEM_COOLER 0
75-
#define ITEM_FAN 1
76-
#define ITEMS_COUNT 2
77-
#elif HAS_MULTI_HOTEND
78-
#define ITEM_E0 0
79-
#define ITEM_E1 1
80-
#define ITEM_BED 2
81-
#define ITEM_FAN 3
82-
#define ITEMS_COUNT 4
83-
#else
84-
#define ITEM_E0 0
85-
#define ITEM_BED 1
86-
#define ITEM_FAN 2
87-
#define ITEMS_COUNT 3
88-
#endif
60+
enum {
61+
OPTITEM(HAS_EXTRUDERS, ITEM_E0)
62+
OPTITEM(HAS_MULTI_HOTEND, ITEM_E1)
63+
#if HOTENDS > 2
64+
ITEM_E2,
65+
#endif
66+
OPTITEM(HAS_HEATED_BED, ITEM_BED)
67+
OPTITEM(HAS_TEMP_CHAMBER, ITEM_CHAMBER)
68+
OPTITEM(HAS_TEMP_COOLER, ITEM_COOLER)
69+
OPTITEM(HAS_FAN, ITEM_FAN)
70+
ITEMS_COUNT
71+
};

0 commit comments

Comments
 (0)