Skip to content

Commit f281fb4

Browse files
committed
🎨 Minor code cleanup
1 parent a256e47 commit f281fb4

File tree

5 files changed

+27
-40
lines changed

5 files changed

+27
-40
lines changed

Marlin/src/lcd/extui/ftdi_eve_touch_ui/cocoa_press/files_screen.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ const char *FilesScreen::getSelectedFilename(bool shortName) {
7777
}
7878

7979
void FilesScreen::drawSelectedFile() {
80-
if(mydata.selected_tag == 0xFF) return;
80+
if (mydata.selected_tag == 0xFF) return;
8181
FileList files;
8282
files.seek(getSelectedFileIndex(), true);
8383
mydata.flags.is_dir = files.isDir();

Marlin/src/lcd/extui/ftdi_eve_touch_ui/cocoa_press/load_chocolate.cpp

+12-25
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,10 @@ void LoadChocolateScreen::draw_buttons(draw_mode_t what) {
5454
cmd.tag(3).colors(mydata.repeat_tag == 6 ? action_btn : normal_btn).button(x, y, h, v, GET_TEXT_F(MSG_LOAD));
5555

5656
ui.bounds(POLY(load_screen_start_stop_btn), x, y, h, v);
57-
if(mydata.repeat_tag == 0) {
58-
cmd.colors(normal_btn).enabled(false);
59-
} else {
60-
cmd.colors(mydata.repeating ? action_btn : normal_btn).enabled(true);
61-
}
57+
if (mydata.repeat_tag == 0)
58+
cmd.colors(normal_btn).enabled(false);
59+
else
60+
cmd.colors(mydata.repeating ? action_btn : normal_btn).enabled(true);
6261
cmd.tag(4).button(x, y, h, v, GET_TEXT_F(MSG_START_STOP));
6362

6463
ui.bounds(POLY(load_screen_back_btn), x, y, h, v);
@@ -115,24 +114,16 @@ void LoadChocolateScreen::onRedraw(draw_mode_t what) {
115114
}
116115

117116
bool LoadChocolateScreen::onTouchStart(uint8_t tag) {
118-
if(tag != 4) {
119-
mydata.repeating = false;
120-
}
117+
if (tag != 4) mydata.repeating = false;
121118
return true;
122119
}
123120

124121
bool LoadChocolateScreen::onTouchEnd(uint8_t tag) {
125122
using namespace ExtUI;
126123
switch (tag) {
127-
case 2:
128-
mydata.repeat_tag = 5;
129-
break;
130-
case 3:
131-
mydata.repeat_tag = 6;
132-
break;
133-
case 4:
134-
mydata.repeating = !mydata.repeating;
135-
break;
124+
case 2: mydata.repeat_tag = 5; break;
125+
case 3: mydata.repeat_tag = 6; break;
126+
case 4: mydata.repeating = !mydata.repeating; break;
136127
case 1: GOTO_PREVIOUS(); break;
137128
}
138129
return true;
@@ -153,12 +144,8 @@ bool LoadChocolateScreen::onTouchHeld(uint8_t tag) {
153144
#define UI_INCREMENT_AXIS(axis) UI_INCREMENT(AxisPosition_mm, axis);
154145
#define UI_DECREMENT_AXIS(axis) UI_DECREMENT(AxisPosition_mm, axis);
155146
switch (tag) {
156-
case 5:
157-
UI_INCREMENT_AXIS(E0);
158-
break;
159-
case 6:
160-
UI_DECREMENT_AXIS(E0);
161-
break;
147+
case 5: UI_INCREMENT_AXIS(E0); break;
148+
case 6: UI_DECREMENT_AXIS(E0); break;
162149
default: return false;
163150
}
164151
#undef UI_DECREMENT_AXIS
@@ -170,10 +157,10 @@ void LoadChocolateScreen::onIdle() {
170157
reset_menu_timeout();
171158
if (mydata.repeating) onTouchHeld(mydata.repeat_tag);
172159
if (refresh_timer.elapsed(STATUS_UPDATE_INTERVAL)) {
173-
if (!EventLoop::is_touch_held())
174-
onRefresh();
160+
if (!EventLoop::is_touch_held()) onRefresh();
175161
refresh_timer.start();
176162
}
177163
BaseScreen::onIdle();
178164
}
165+
179166
#endif // COCOA_LOAD_CHOCOLATE_SCREEN

Marlin/src/lcd/extui/ftdi_eve_touch_ui/cocoa_press/status_screen.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -271,22 +271,23 @@ void StatusScreen::draw_file(draw_mode_t what) {
271271
if (what & FOREGROUND) {
272272
cmd.cmd(COLOR_RGB(bg_text_enabled));
273273

274-
if(!isMediaInserted())
274+
if (!isMediaInserted())
275275
draw_text_with_ellipsis(cmd, TEXT_POS(x, y, w, h), F("No media present"), OPT_CENTERY, font_small);
276-
else if(isFileSelected()) {
276+
else if (isFileSelected()) {
277277
FileList list;
278278
draw_text_with_ellipsis(cmd, TEXT_POS(x, y, w, h), list.filename(), OPT_CENTERY, font_small);
279-
} else
279+
}
280+
else
280281
draw_text_with_ellipsis(cmd, TEXT_POS(x, y, w, h), F("No file selected"), OPT_CENTERY, font_small);
281282
}
282283
}
283284

284285
bool StatusScreen::isFileSelected() {
285-
if(!isMediaInserted()) return false;
286+
if (!isMediaInserted()) return false;
286287
FileList list;
287-
if(list.isDir()) return false;
288+
if (list.isDir()) return false;
288289
const char *filename = list.filename();
289-
if(filename[0] == '\0') return false;
290+
if (filename[0] == '\0') return false;
290291
return true;
291292
}
292293

@@ -368,8 +369,7 @@ void StatusScreen::setStatusMessage(const char * const) {
368369
void StatusScreen::onIdle() {
369370
reset_menu_timeout();
370371
if (refresh_timer.elapsed(STATUS_UPDATE_INTERVAL)) {
371-
if (!EventLoop::is_touch_held())
372-
onRefresh();
372+
if (!EventLoop::is_touch_held()) onRefresh();
373373
refresh_timer.start();
374374
}
375375
}

Marlin/src/lcd/extui/ia_creality/ia_creality_rts.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ void RTS::onIdle() {
220220
break;
221221

222222
case 3:
223-
//if(isPositionKnown() && (getActualTemp_celsius(BED) >= (getTargetTemp_celsius(BED)-1))) {
223+
//if (isPositionKnown() && (getActualTemp_celsius(BED) >= (getTargetTemp_celsius(BED)-1))) {
224224
rts.sendData(ExchangePageBase + 64, ExchangepageAddr);
225225
waitway = 7;
226226
//return;
@@ -1559,7 +1559,7 @@ void RTS::handleData() {
15591559
else if (recdat.data[0] == 2) { // Page Down
15601560
if ((fileIndex + DISPLAY_FILES) < (filenavigator.maxFiles() + (filenavigator.folderdepth != 0))) {
15611561
fileIndex = fileIndex + DISPLAY_FILES;
1562-
// if(filenavigator.folderdepth!=0 && fileIndex!=0) //Shift to acknowledge Return DIR button on first page
1562+
// if (filenavigator.folderdepth!=0 && fileIndex!=0) //Shift to acknowledge Return DIR button on first page
15631563
// filenavigator.getFiles(fileIndex-1);
15641564
// else
15651565
filenavigator.getFiles(fileIndex);
@@ -1569,7 +1569,7 @@ void RTS::handleData() {
15691569
else if (recdat.data[0] == 3) { // Page Up
15701570
if (fileIndex >= DISPLAY_FILES) {
15711571
fileIndex = fileIndex - DISPLAY_FILES;
1572-
// if(filenavigator.folderdepth!=0 && fileIndex!=0) //Shift to acknowledge Return DIR button on first page
1572+
// if (filenavigator.folderdepth!=0 && fileIndex!=0) //Shift to acknowledge Return DIR button on first page
15731573
// filenavigator.getFiles(filenavigator.currentindex-DISPLAY_FILES);
15741574
// else
15751575
filenavigator.getFiles(fileIndex);

Marlin/src/module/stepper/trinamic.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ void reset_trinamic_drivers();
294294
#define U_ENABLE_READ() stepperU.isEnabled()
295295
#endif
296296
#if AXIS_HAS_DEDGE(U)
297-
#define U_STEP_WRITE(STATE) do{ if(STATE) TOGGLE(U_STEP_PIN); }while(0)
297+
#define U_STEP_WRITE(STATE) do{ if (STATE) TOGGLE(U_STEP_PIN); }while(0)
298298
#endif
299299
#endif
300300

@@ -308,7 +308,7 @@ void reset_trinamic_drivers();
308308
#define V_ENABLE_READ() stepperV.isEnabled()
309309
#endif
310310
#if AXIS_HAS_DEDGE(V)
311-
#define V_STEP_WRITE(STATE) do{ if(STATE) TOGGLE(V_STEP_PIN); }while(0)
311+
#define V_STEP_WRITE(STATE) do{ if (STATE) TOGGLE(V_STEP_PIN); }while(0)
312312
#endif
313313
#endif
314314

@@ -322,7 +322,7 @@ void reset_trinamic_drivers();
322322
#define W_ENABLE_READ() stepperW.isEnabled()
323323
#endif
324324
#if AXIS_HAS_DEDGE(W)
325-
#define W_STEP_WRITE(STATE) do{ if(STATE) TOGGLE(W_STEP_PIN); }while(0)
325+
#define W_STEP_WRITE(STATE) do{ if (STATE) TOGGLE(W_STEP_PIN); }while(0)
326326
#endif
327327
#endif
328328

0 commit comments

Comments
 (0)