Skip to content

Commit dc91bc4

Browse files
[FlexNG] Set MinSizeShouldEncompassIntrinsicSize
SetMinBlockSizeShouldEncompassIntrinsicSize() on a flex item to allow the item to grow as a result of fragmentation. In order for this flag to have an effect on flex items inside a column flex container, we also had to SetIsFixedBlockSize() to false. This will be used to expand the flex lines if needed. Bug: 660611 Change-Id: I8890cc54262c14664706b9cb9efb141a453dceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3276791 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#941410}
1 parent f658673 commit dc91bc4

File tree

2 files changed

+30
-0
lines changed

2 files changed

+30
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<!DOCTYPE html>
2+
<title>
3+
Tests that a flex-item grows due to fragmentation.
4+
</title>
5+
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#pagination">
6+
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
7+
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
8+
<div style="width: 100px; height: 100px; columns: 2; column-gap: 0; background: red;">
9+
<div style="display: flex; flex-direction: column;">
10+
<div style="line-height: 0; background: green;">
11+
<div style="display: inline-block; width: 50px; height: 50px;"></div>
12+
<div style="display: inline-block; width: 50px; height: 100px;"></div>
13+
</div>
14+
</div>
15+
</div>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<!DOCTYPE html>
2+
<title>
3+
Tests that a flex-item with a fixed block-size container grows due to fragmentation.
4+
</title>
5+
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#pagination">
6+
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht">
7+
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
8+
<div style="width: 100px; height: 100px; columns: 2; column-gap: 0; background: red;">
9+
<div style="display: flex; flex-direction: column; height: 100px;">
10+
<div style="line-height: 0; background: green;">
11+
<div style="display: inline-block; width: 50px; height: 50px;"></div>
12+
<div style="display: inline-block; width: 50px; height: 100px;"></div>
13+
</div>
14+
</div>
15+
</div>

0 commit comments

Comments
 (0)