Skip to content

Commit f22f73e

Browse files
Fix issue in dh_genprime.c where the error code returned by mbedtls_mpi_write_file() is incorrectly reported on failure
Signed-off-by: Aditya Deshpande <aditya.deshpande@arm.com>
1 parent 4637ed2 commit f22f73e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Bugfix
2+
* Fix bug in error reporting in dh_genprime.c where upon failure,
3+
the error code returned by mbedtls_mpi_write_file() is overwritten
4+
and therefore not printed.

programs/pkey/dh_genprime.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,8 @@ int main( int argc, char **argv )
161161
goto exit;
162162
}
163163

164-
if( ( ret = mbedtls_mpi_write_file( "P = ", &P, 16, fout ) != 0 ) ||
165-
( ret = mbedtls_mpi_write_file( "G = ", &G, 16, fout ) != 0 ) )
164+
if( ( ( ret = mbedtls_mpi_write_file( "P = ", &P, 16, fout ) ) != 0 ) ||
165+
( ( ret = mbedtls_mpi_write_file( "G = ", &G, 16, fout ) ) != 0 ) )
166166
{
167167
mbedtls_printf( " failed\n ! mbedtls_mpi_write_file returned %d\n\n", ret );
168168
fclose( fout );

0 commit comments

Comments
 (0)