-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL to original post is not correctly federated to Misskey #1484
Comments
Yeah I gotta say that the issue is a misskey one to be honest. Have you checked how a lemmy post looks on misskey? |
Yes, please open the link at Expected behavior. |
I also checked on Mastodon and there is the same problem. You can check by searching me, open my profile and scroll down to the Linux Memes post (can't link to it directly as Mastodon would initiate a redirect to the media-url). |
And is this working with a link post? Or is the "wrong" behaviour on Misskey or Mastodon as well? We use the |
Link-Posts from Mbin also don't get a link to the original post (in neither Misskey nor Mastodon) and as it seems won't even have an image-preview. I don't know what Lemmy is doing differently, and I don't have a Lemmy Account, so I can't really run tests. |
After checking the object lemmy produces, it is relatively simple to fix. We currently use the {
"type": "Page",
"id": "https://mbin.tld/...",
"attachment": [
{
"href": "https://site.tld/link",
"mediaType": "text/html; charset=utf-8",
"type": "Link"
}
],
"..."
} Which we can parse already, I was actually not aware of this. |
Interesting to know. This makes me wonder what the "right" (as in "intended by the ActivityPub Specs") design is? Was the Lemmy way according to spec or did they do their own thing and others adjusted? (Not that I have a saying in this, but it is kinda interesting to think about Fedi governance.) |
I am always on the side of "going with the flow" when it comes to AP as the spec is so loose. However, the spec says this:
So I think we are off spec here... |
Describe the bug
When an image-post is created in Mbin and then viewed on a Misskey instance, the post will link to the image-file, not the post on the Mbin instance.
On which Mbin instance did you find the bug?
fedia.io
Which Mbin version was running on the instance?
1.8.0
To Reproduce
Steps to reproduce the behavior:
https://fedia.io/m/linuxmemes@lemmy.world/new/photo
)-> The media is embedded correctly, but the link at the bottom only points to the image, not the post itself.
Expected behavior
An example for correct behavior can be seen here.
The link-panel at the bottom of the post will link to the Lemmy-post.
Desktop (please complete the following information):
Smartphone (please complete the following information):
not tested
Additional context
I am not sure if the issue is in Mbin or Misskey. If you think the second option is the case, I will create an issue at Misskeys repo.
The text was updated successfully, but these errors were encountered: