Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show lemmy banners #613

Open
aaronliu0130 opened this issue Mar 21, 2024 · 8 comments
Open

Show lemmy banners #613

aaronliu0130 opened this issue Mar 21, 2024 · 8 comments
Labels
activitypub ActivityPub related issues enhancement New feature or request
Milestone

Comments

@aaronliu0130
Copy link

aaronliu0130 commented Mar 21, 2024

Is your feature request related to a problem? Please describe.
Currently, banners such as these on the top at https://lemmy.dbzer0.com/c/piracy aren't displayed at all in kbin/mbin.

Describe the solution you'd like
Add the banner below the federated community warning. Maybe even support banners for local magazines

Describe alternatives you've considered
Make it the background picture

@aaronliu0130 aaronliu0130 added the enhancement New feature or request label Mar 21, 2024
@aaronliu0130 aaronliu0130 changed the title Show banners Show lemmy banners Mar 21, 2024
@e-five256
Copy link
Member

e-five256 commented Mar 21, 2024

[info] the banner appears to be given as part of the "image" field in the activity pub group object response

  "image": {
    "type": "Image",
    "url": "https://lemmy.dbzer0.com/pictrs/image/0fa4f7d0-4dda-43e0-8750-ee43d218a8ea.webp"
  }

We use "icon" for the avatar but I do not think we currently send or parse an "image"

@BentiGorlich
Copy link
Member

Where would we display the banner? We don't really have a place for it in our interface 🤔
We could maybe just put it at the top of list view, but I don't think it would look too good...

@aaronliu0130
Copy link
Author

aaronliu0130 commented Mar 23, 2024

Either top of list view or under the "(un)subscribe" button

Copy link
Contributor

This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days.

@github-actions github-actions bot added the Stale Inactivity for too long label May 13, 2024
@aaronliu0130
Copy link
Author

aaronliu0130 commented May 13, 2024

cute li'l girl wagging out "nope"

@BentiGorlich BentiGorlich removed the Stale Inactivity for too long label May 13, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This issue is stale because it has been open 50 days with no activity. Remove stale label or comment or this will be closed in 6 days.

@github-actions github-actions bot added the Stale Inactivity for too long label Jul 3, 2024
@aaronliu0130
Copy link
Author

aaronliu0130 commented Jul 3, 2024

Eggsy from the Kingsman gentleman spy parody movie chews and winks

@github-actions github-actions bot removed the Stale Inactivity for too long label Jul 4, 2024
@MrLuxuri
Copy link

MrLuxuri commented Oct 7, 2024

Reviving this topic back again, banners have long been used by Reddit moderators to help expand on what "a community is about" from the logo/icon/pfp of the community and this is a feature Lemmy is also on-par with. It plays a huge part on making sure every community comes out with it's own distinct look and appeal.

Unfortunately Kbin never had this, I used to moderate some of the biggest communities on kbin.social such as AskKbin and etc, one of the issues we faced was the lack of this feature and we had to mess around with CSS to get a banner working (and placed it as shown in below image), but it was always messy and never worked well out of the box.

The below is where we could place the banner appropriately on Mbin:

Screen Shot 2024-10-07 at 2 24 48 PM

Basically, the size of the current default posts shown in the magazine's homepage, place it right above the posts as shown in the above image. (Sorry for the inaccurate red box, it is slightly leaning outside towards the right, so it's not exact but to give a visual idea as to where we can potentially place it).

This Aspect ratio should work perfectly fine, and is similar to Reddit Medium size banners, slightly wider than lemmy but again, each of these platforms don't exactly follow a certain aspect ratio, but I have tinkered around my using subreddit banners I used to use on reddit on lemmy and despite minor difference in aspect ratio it mostly worked fine.

I hope this is something Mbin gets on-par with reddit, as this is something we missed on Kbin.

@BentiGorlich BentiGorlich added this to the v1.8.0 milestone Oct 7, 2024
@BentiGorlich BentiGorlich modified the milestones: v1.8.0, v1.8.1 Nov 22, 2024
@garrettw garrettw added the activitypub ActivityPub related issues label Jan 1, 2025
@melroy89 melroy89 modified the milestones: v1.8.1, v1.8.2 Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activitypub ActivityPub related issues enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

6 participants