Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really want to store all the label columns in every task dataframe even when the task will just have one kind of label? #42

Open
mmcdermott opened this issue Aug 8, 2024 · 2 comments · May be fixed by #70
Labels
enhancement New feature or request Label Schema For the MEDS label schema priority:low Low priority; does not need to be included in any upcoming release candidates. Usability For the usability of the MEDS schema more generally by the community at a technical level.

Comments

@mmcdermott
Copy link
Contributor

@EthanSteinberg, should we somehow indicate that the label columns are optional or don't all need to be included? It seems silly that we'll need to make every label dataframe have columns for every kind of task when all but one will be empty.

# Possible values for the label.

@EthanSteinberg
Copy link
Collaborator

I'd be open to that, but I'm not sure the best way to do it

@mmcdermott
Copy link
Contributor Author

I don't think there is a clean way to support it, after googling around a bit. If/when we solve #37 we can integrate this capability in there (e.g., make it so that if you use meds utilities to re-cast and/or validate and/or read your data in the specified schemas, optional columns are enforced and/or cast to the right types if they are present but no issue is raised if they are not?

I also filed apache/arrow#43626 but I don't know if this is in scope or something they'd want on their end.

@mmcdermott mmcdermott added enhancement New feature or request priority:low Low priority; does not need to be included in any upcoming release candidates. Label Schema For the MEDS label schema Usability For the usability of the MEDS schema more generally by the community at a technical level. labels Jan 7, 2025
@mmcdermott mmcdermott linked a pull request Mar 7, 2025 that will close this issue
@mmcdermott mmcdermott linked a pull request Mar 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Label Schema For the MEDS label schema priority:low Low priority; does not need to be included in any upcoming release candidates. Usability For the usability of the MEDS schema more generally by the community at a technical level.
Projects
None yet
2 participants