Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings and Keybindings editor do not retain filters when moved across editor groups #26490

Closed
Tekbr opened this issue May 11, 2017 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues settings-editor VS Code settings editor issues
Milestone

Comments

@Tekbr
Copy link

Tekbr commented May 11, 2017

Steps to reproduce

Keyboard Shortcuts - Second Situation:

  • Open any file in editor group 1
  • Open Keyboard Shortcuts / Settings editor in editor group 1 and provide a filter
  • Open any file in editor group 2
  • Move the Keyboard Shortcuts / Settings editor from group 1 to group 2

Expected: Filter is retained
Observed: Filter is not retained

@sandy081
Copy link
Member

Duplicates #23543

@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label May 12, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
@sandy081 sandy081 added keybindings-editor Keybinding editor issues info-needed Issue requires more information from poster settings-editor VS Code settings editor issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Nov 28, 2017
@sandy081 sandy081 reopened this Nov 28, 2017
@sandy081 sandy081 changed the title Shortcuts and Settings Keyboard search field does not retain what I typed when changing tab or editor group Settings and Keybindings editor do not retain filters when moved across editor groups Nov 28, 2017
@sandy081
Copy link
Member

sandy081 commented Nov 28, 2017

@Tekbr Reopened as mentioned in #23543.

I see what you mean.

Updated the description and summary.

Thanks for mentioning this scenario

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Nov 28, 2017
@sandy081 sandy081 added this to the November 2017 milestone Nov 28, 2017
@microsoft microsoft unlocked this conversation Nov 29, 2017
@Tekbr
Copy link
Author

Tekbr commented Nov 29, 2017

-- Sorry for the English, I used Google Translator --

Thank you for unlocking the comments. 👍

I think preserving state is good and helpful. There was feedback to retain it.

@sandy081 Responding to your comment:

I looked at all the cases, and I did not find any that said so. It could be that Google Translator betrayed me. 🤔

Can you show me where?

I agree that while the Settings / keybindings is open and I switch to another tab, fine, but closing the Settings / keybindings and then opening again and text continue there, it becomes kinda bad to my view.

@sandy081
Copy link
Member

sandy081 commented Dec 3, 2017

@Tekbr You are right that the duplicates do not talk about closing and reopening the editor. But, I have not heard any negative feedback for retaining the filter when closed and reopened in settings editor. So not sure, changing the behaviour might not be liked by other set of users.

I will create a separate issue for this scenario and how the community reacts to it - #39512

@sandy081 sandy081 removed the info-needed Issue requires more information from poster label Dec 4, 2017
@sandy081 sandy081 modified the milestones: November 2017, December 2017 Dec 6, 2017
@sandy081 sandy081 modified the milestones: January 2018, Backlog Jan 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

2 participants