Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from the obsolete SeccompProfilePath #198

Closed
nwneisen opened this issue Jun 6, 2023 · 1 comment
Closed

Migrate from the obsolete SeccompProfilePath #198

nwneisen opened this issue Jun 6, 2023 · 1 comment
Labels

Comments

@nwneisen
Copy link
Collaborator

nwneisen commented Jun 6, 2023

GetSeccompProfilePath() is deprecated but still being used by cri-dockerd. A recent change to cri-tools migrates the tests from using the old method and instead switches to the new method. This causes our integration and e2e tests to fail due to still using the old method.

This issue is to make the changes to support the new method of retrieving the seccomp profile.

Note
As a temporary work around (this is causing all builds to fail), we can pin the cri-tools to the commit before the change using

      - name: Check out cri-tools
        uses: actions/checkout@v2
        with:
          repository: kubernetes-sigs/cri-tools
          path: src/sigs.k8s.io/cri-tools
          ref: e3c99451faee42de2fcf4568bdd81be8bb29e40f

as I've done in #197. This will let us move on with other changes until we have the fix in for this.

@nwneisen
Copy link
Collaborator Author

Fixed in #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant