google.call and llm.call x logfire

[CharlesOural]

Description

When there is an error 503 server side or if there is a tenacity error it don't show in the logfire span.

Very difficult to provide a test code, because you need to emulate a serverside error from the provider.

But if I understand correctly if there is an error we need to do :

e._response = response
raise e

maybe check if this flow is properly done inside google.call and llm.call ?

Tell me if you need anything

Python, Mirascope & OS Versions, related packages (not required)

python 3.12
mirascope latest 1.20.1

[willbakst]

Can you patch the client call with a side effect to reproduce?

[willbakst]

On the tenacity side, that makes sense? Tenacity is catching the error and making another call? Or are you saying if tenacity fails completely and throws a RetryError that that isn't caught?

Without a minimal repro it's hard to know what's going on

[CharlesOural]

Humm I think this was when we received a 503 from google for example, but it's normal that there is no response (the model crashed) so I think this was not on your end...

[willbakst]

Feel free to reopen if it turns out it's something on our end :)