Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] - Gateway should deserialize object contents #1313

Closed
kyleqian opened this issue Apr 11, 2022 · 8 comments
Closed

[RPC] - Gateway should deserialize object contents #1313

kyleqian opened this issue Apr 11, 2022 · 8 comments
Assignees
Labels
Type: Enhancement New feature or request
Milestone

Comments

@kyleqian
Copy link
Contributor

kyleqian commented Apr 11, 2022

Currently the rest server outputs raw ObjectRead data for /api/object_info, as in:

"contents": "OFd2cCAFyXlxzUXP/dMQmHG+k1QAAAAAAAAAAKCGAQAAAAAA"

Ideally it should serialize to something readable, like json, similar to what the wallet CLI already does.

@kyleqian kyleqian added the Type: Enhancement New feature or request label Apr 11, 2022
@patrickkuo
Copy link
Contributor

@oxade FYI

@patrickkuo patrickkuo linked a pull request Apr 14, 2022 that will close this issue
@todd-mystenlabs
Copy link
Contributor

todd-mystenlabs commented Apr 18, 2022

Are we keeping the rest server endpoints for devnet? I thought we were dropping the rest endpoints and going with json-rpc over https?
cc: @lxfind @patrickkuo

i.e. are we going to be able to hit /api/object_info with a REST verb?

@patrickkuo
Copy link
Contributor

This endpoint will be port to JSON-RPC, instead of /api/object_info, the same functionality will be accessible via json RPC. We will remove the rest server after JSON-RPC is ready.

@gdanezis
Copy link
Collaborator

Ok, so we will never do this? Should we close the issue?

@kyleqian
Copy link
Contributor Author

This isn't specific to REST api - it's about returning object contents in a readable format to clients.

@patrickkuo
Copy link
Contributor

Lets keep this open to make sure we fix this in RPC

@patrickkuo patrickkuo reopened this Apr 19, 2022
@patrickkuo patrickkuo changed the title Gateway should deserialize object contents [RPC] - Gateway should deserialize object contents Apr 19, 2022
@patrickkuo patrickkuo added this to the DevNet milestone Apr 19, 2022
@patrickkuo
Copy link
Contributor

Related to this #237

@patrickkuo
Copy link
Contributor

this is fixed by #1440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants