Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Wallet would crash if the number of arguments don't match when making a Move call transaction #1330

Closed
lxfind opened this issue Apr 12, 2022 · 2 comments · Fixed by #1675
Assignees
Labels
devx Type: Bug Something isn't working
Milestone

Comments

@lxfind
Copy link
Contributor

lxfind commented Apr 12, 2022

Looks like any error will lead to wallet crash.

@patrickkuo
Copy link
Contributor

@lxfind do you have an example to reproduce this bug? I tried ObjectBasics and it seems to work fine.

sui>-$ call --package 0x2 --module ObjectBasics --function create --args 10000 "0xE568D48758DC0C33B0259DA10582FDEDA2ED5C06" --gas B940ADB0D5C5F106239705265B1674F89969296D --gas-budget 1000
----- Certificate ----
Signed Authorities : [k#2b5711e256efeeaa894a21486c2a0fb28c503c79c4b7e7124e4c3f6718c585be, k#b821e1f99d72821e973960faa3242f9b5bb5ede274696118416c08e45d569be6, k#86c12fd2e2099d6b788241c27cc5a88e474a1fad835bd918512657792cb26f0c]
Transaction Kind : Call
Package ID : 0x2
Module : ObjectBasics
Function : create
Arguments : [Pure([16, 39, 0, 0, 0, 0, 0, 0]), Pure([229, 104, 212, 135, 88, 220, 12, 51, 176, 37, 157, 161, 5, 130, 253, 237, 162, 237, 92, 6])]
Type Arguments : []

----- Transaction Effects ----
Status : Success { gas_cost: GasCostSummary { computation_cost: 212, storage_cost: 28, storage_rebate: 15 } }
Created Objects:
F6D36176B85619D70824042F42D1F2C0142FD212 SequenceNumber(1) o#ea9d0a7c6cb86cf9828fac206ca9824fa5153216b57e5771139a1eb6ae3f373a
Mutated Objects:
B940ADB0D5C5F106239705265B1674F89969296D SequenceNumber(2) o#5372bcf4e5d9554da26605b1dc4245e4414f5a04b20ed37f76d46bac843714ff
sui>-$ call --package 0x2 --module ObjectBasics --function create --args 10000 "0xE568D48758DC0C33B0259DA10582FDEDA2ED5C06" 1000  --gas B940ADB0D5C5F106239705265B1674F89969296D --gas-budget 1000
Expected 2 args, found 3
sui>-$ call --package 0x2 --module ObjectBasics --function create --args 10000 --gas B940ADB0D5C5F106239705265B1674F89969296D --gas-budget 1000
Expected 2 args, found 1
sui>-$ 

@lxfind
Copy link
Contributor Author

lxfind commented Apr 27, 2022

Basically just try to trigger any tx error, and it will panic eventually.
Say go to an arbitrary dir and do:

wallet publish --path . --gas-budget 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants