Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] The ID type in our Move framework should no longer be called ID #291

Closed
lxfind opened this issue Jan 28, 2022 · 1 comment · Fixed by #493
Closed

[cleanup] The ID type in our Move framework should no longer be called ID #291

lxfind opened this issue Jan 28, 2022 · 1 comment · Fixed by #493
Assignees
@666lcz

Comments

@lxfind
Copy link
Contributor

lxfind commented Jan 28, 2022

The ID struct in our Move framework now contains both id and version. We should give it a more appropriate name (like ObjectHeader?) And rename all references to it.
@sblackshear
Copy link
Collaborator

Agreed. VersionedID was one naming thought I had (but ObjectHeader or ObjectMetadata also makes sense). It makes me a little bit sad because ID is ubiquitous + a short name, but clarity is more important...

@666lcz 666lcz self-assigned this Feb 20, 2022
@666lcz 666lcz mentioned this issue Feb 20, 2022
Merged
@666lcz 666lcz linked a pull request Feb 20, 2022 that will close this issue
[cleanup] Rename type ID in Move Framework to VersionedID #493
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@666lcz 666lcz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cleanup] Rename type ID in Move Framework to VersionedID MystenLabs/sui
3 participants
@lxfind @sblackshear @666lcz