Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Bench error introduced in #337 #429

Closed
huitseeker opened this issue Feb 11, 2022 · 0 comments · Fixed by #431
Closed

[bug] Bench error introduced in #337 #429

huitseeker opened this issue Feb 11, 2022 · 0 comments · Fixed by #431
Assignees
@awelc
Labels
Type: Bug Something isn't working

Comments

@huitseeker
Copy link
Contributor

Since commit d75b684
Running the bench on the main repo:
cargo run --release --bin bench
Generates the following errors:
https:////gist.github.com/6d22671ed2054ce39bf59af769f6ba06

It seems this is due to #337 specifically the change introduced in
https://github.com/MystenLabs/fastnft/pull/337/files#diff-61b6b3044f10d90c3ea29b5a9cc8f3ad5f1b3ae25b381d84249e2092dffab8f8L316-L317
@huitseeker huitseeker added the Type: Bug Something isn't working label Feb 11, 2022
@awelc awelc mentioned this issue Feb 11, 2022
Closed
@awelc awelc linked a pull request Feb 11, 2022 that will close this issue
[bench] Check failure instead #431
Merged
@oxade oxade mentioned this issue Feb 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awelc awelc

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bench] Check failure instead MystenLabs/sui
2 participants
@huitseeker @awelc