Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[programmability] Framework Sources Dir Is Compile Time Constant #448

Closed
oxade opened this issue Feb 14, 2022 · 1 comment · Fixed by #461
Closed

[programmability] Framework Sources Dir Is Compile Time Constant #448

oxade opened this issue Feb 14, 2022 · 1 comment · Fixed by #461
Assignees
@patrickkuo
Labels
Type: Bug Something isn't working

Comments

@oxade
Copy link
Contributor

oxade commented Feb 14, 2022

Framework dir is set as env!("CARGO_MANIFEST_DIR").
This means is the sui binary is run from a different directory, the framework sources will not be found and sui will not run.

This is blocking efficient containerization efforts because we now have to build the binaries on the container which adds space and time cost.
@oxade oxade added the Type: Bug Something isn't working label Feb 14, 2022
@oxade oxade assigned oxade and patrickkuo and unassigned oxade Feb 14, 2022
@oxade
Copy link
Contributor Author

oxade commented Feb 16, 2022

Patrick will handle this as part of #461

@patrickkuo patrickkuo linked a pull request Feb 16, 2022 that will close this issue
[fastx CLI] Add customisation to genesis #461
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickkuo patrickkuo

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fastx CLI] Add customisation to genesis MystenLabs/sui
2 participants
@patrickkuo @oxade