Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sui][refactor] Remove IDBytes #499

Closed
666lcz opened this issue Feb 20, 2022 · 1 comment · Fixed by #580
Closed

[sui][refactor] Remove IDBytes #499

666lcz opened this issue Feb 20, 2022 · 1 comment · Fixed by #580
Assignees
@sblackshear

Comments

@666lcz
Copy link
Contributor

666lcz commented Feb 20, 2022

Per comments in #493, move IDBytes to a different module--I think this will allow us to fix a lot of the horribly confusing naming (that I am responsible for, apologies) of functions that return ID vs IDBytes
@lxfind lxfind changed the title [sui][refactor] Move IDBytes to a different module [sui][refactor] Remove IDBytes Feb 26, 2022
@lxfind
Copy link
Contributor

lxfind commented Feb 26, 2022

Now that IDBytes is just a thin wrapper of address, we no longer needs it.

@sblackshear sblackshear self-assigned this Feb 26, 2022
@sblackshear sblackshear mentioned this issue Feb 26, 2022
Merged
@666lcz 666lcz closed this as completed Mar 1, 2022
@666lcz 666lcz linked a pull request Mar 1, 2022 that will close this issue
[Sui Framework] Better types and API's in ID module #580
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sblackshear sblackshear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Sui Framework] Better types and API's in ID module sblackshear/fastnft
3 participants
@lxfind @sblackshear @666lcz