Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sui][refactor] Prevent developers from reading version #500

Closed
666lcz opened this issue Feb 20, 2022 · 0 comments · Fixed by #580
Closed

[sui][refactor] Prevent developers from reading version #500

666lcz opened this issue Feb 20, 2022 · 0 comments · Fixed by #580

Comments

@666lcz
Copy link
Contributor

666lcz commented Feb 20, 2022

Per comments in #493, We could consider rearranging the API's to prevent Move programmers from reading the version altogether... it's not used by any application code right now, and writing code that reads the version is bound to be hard for tools like the Move prover to reason about because the logic for updating it lives in the adapter. In addition, the new testing code doesn't mock versions (and it would be tricky to change it to do so), so this change would also prevent folks from writing tests that won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant