Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastx crypto] audit Object ID derivation #58

Closed
sblackshear opened this issue Dec 15, 2021 · 2 comments
Closed

[fastx crypto] audit Object ID derivation #58

sblackshear opened this issue Dec 15, 2021 · 2 comments
Assignees
@kchalkias
Milestone
[A] Internal Testing

Comments

@sblackshear
Copy link
Collaborator

sblackshear commented Dec 15, 2021 •
edited
Loading

We need to define a ObjectIDPreimage struct that holds (transaction_id, new_obj_sequence), then make it BcsSignable and use sha3_hash to get the digest. This ensures that we have one way to derive hashes (incl. for what we sign) and therefore domain separation is ensured uniformly..
@gdanezis gdanezis self-assigned this Jan 4, 2022
@gdanezis gdanezis linked a pull request Jan 4, 2022 that will close this issue
feat: We add and track crypto digests to orders and objects #117
Merged
@huitseeker huitseeker mentioned this issue Jan 5, 2022
Merged
@gdanezis gdanezis removed a link to a pull request Jan 6, 2022
feat: We add and track crypto digests to orders and objects #117
Merged
@gdanezis gdanezis assigned kchalkias and unassigned gdanezis Jan 6, 2022
@gdanezis gdanezis mentioned this issue Jan 10, 2022
Merged
@lxfind lxfind added this to the TBD milestone Jan 21, 2022
@bholc646 bholc646 removed this from the TBD milestone Apr 6, 2022
@gdanezis gdanezis mentioned this issue Apr 19, 2022
Open
@gdanezis gdanezis added this to the Pre Testnet milestone Apr 19, 2022
@kchalkias
Copy link
Collaborator

The Signable interface might be deprecated after introducing IntentSigning, which is a unified (lang-agnostic) way to offer domain separation re what we're signing.

@sblackshear
Copy link
Collaborator Author

Great news! I will close this, in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kchalkias kchalkias

Labels
None yet
Projects
None yet
Milestone
[A] Internal Testing
Development

No branches or pull requests
5 participants
@lxfind @sblackshear @gdanezis @kchalkias @bholc646