Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:datepicker): ngModel not update #7948

Merged
merged 2 commits into from
May 15, 2023

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented May 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

This PR is a fix for this issue: #7946

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

When focus out for a datepicker that show time, the ngModel is not update.

Issue Number: #7946

What is the new behavior?

For a datePicker taht show time, the ngModel is update when focus out

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Nicoss54 Nicoss54 requested a review from wenqi73 as a code owner May 15, 2023 09:45
@zorro-bot
Copy link

zorro-bot bot commented May 15, 2023

This preview will be available after the AzureCI is passed.

@Nicoss54
Copy link
Collaborator Author

@simplejason, could please rerun the pipeline, I not have suffisant access to do that. Currently the pipeline failed due to a npm registry issue that is fixed.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #7948 (11cec56) into master (ad2faf4) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 11cec56 differs from pull request most recent head 27b0a69. Consider uploading reports for the commit 27b0a69 to get more accurate results

@@            Coverage Diff             @@
##           master    #7948      +/-   ##
==========================================
- Coverage   91.75%   91.74%   -0.02%     
==========================================
  Files         509      509              
  Lines       17445    17447       +2     
  Branches     2683     2685       +2     
==========================================
  Hits        16007    16007              
- Misses       1141     1142       +1     
- Partials      297      298       +1     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 94.67% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@zorro-bot zorro-bot bot requested a review from wenqi73 May 15, 2023 14:25
@Nicoss54 Nicoss54 merged commit 100796c into NG-ZORRO:master May 15, 2023
@Nicoss54 Nicoss54 deleted the fix/ng-model-not-update-timepicker branch May 15, 2023 14:50
MunMunMiao pushed a commit to MunMunMiao/ng-zorro-antd that referenced this pull request May 31, 2023
* fix(module:datepicker): ngModel not update

* fix(module:datepicker): add correct grain
simplejason pushed a commit to simplejason/ng-zorro-antd that referenced this pull request Oct 27, 2023
* fix(module:datepicker): ngModel not update

* fix(module:datepicker): add correct grain

(cherry picked from commit 100796c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgZorro Datepicker with Time Picker Not Updating ngModel on Outside Click in Later Versions
2 participants