feat(module:table): support display and sorting of custom table columns #7966
+607
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7966 +/- ##
==========================================
- Coverage 91.80% 91.80% -0.01%
==========================================
Files 509 510 +1
Lines 17452 17483 +31
Branches 2774 2690 -84
==========================================
+ Hits 16022 16050 +28
- Misses 1136 1137 +1
- Partials 294 296 +2
|
OriginRing
force-pushed
the
feat/custom-column
branch
4 times, most recently
from
ec279b7 to
e13afc9
Compare
yangjunhan
reviewed
May 30, 2023
components/table/doc/index.en-US.md
Outdated
| @@ -150,6 +151,7 @@ Style property | |||
| | `[nzLeft]` | Left pixels, used to fixed column to left, auto calc when set to `true` and disable fixed when `false` | `string \| boolean` | - | | |||
| | `[nzRight]` | Right pixels, used to fixed column to right, auto calc when set to `true` and disable fixed when `false` | `string \| boolean` | - | | |||
| | `[nzAlign]` | Specify how content is aligned | `'left' \| 'right' \| 'center'` | - | | |||
| | `[nzCustomColumnType]` | Set the display and position of columns | `string` | - | | |||
There was a problem hiding this comment.
nzCustomColumnType 可以提供简单的使用方式吗？类似于 th 的 nzWidth vs nzWidthConfig。
还有为什么这个命名是 type？我理解这个值相当于控制显示列的 ID 吧。可以换一个更贴合的语义话名字
| constructor(private el: ElementRef, private renderer: Renderer2, private nzTableDataService: NzTableDataService<T>) {} | ||
|
|
||
| ngOnInit(): void { | ||
| this.nzTableDataService.listOfCustomColumn$.subscribe(item => { |
components/table/doc/index.zh-CN.md
Outdated
| @@ -68,6 +68,7 @@ Table 组件同时具备了易用性和高度可定制性 | |||
| | `[nzData]` | 数据数组 | `T[]` | - | | |||
| | `[nzFrontPagination]` | 是否在前端对数据进行分页，如果在服务器分页数据或者需要在前端显示全部数据时传入 false | `boolean` | `true` | | |||
| | `[nzTotal]` | 当前总数据，在服务器渲染时需要传入 | `number` | - | | |||
| | `[nzCustomColumn]` | 控制表格列的展示与排序 | `NzCustomColumn[]` | - | | |||
There was a problem hiding this comment.
我觉得可以提供一个事件 callback，例如 nzCustomColumnChange，在表格 custom columns 重新展示或排序的时候 emit。
components/table/doc/index.zh-CN.md
Outdated
| @@ -148,6 +149,7 @@ Table 组件同时具备了易用性和高度可定制性 | |||
| | `[nzLeft]` | 左侧距离，用于固定左侧列，当为 `true` 时自动计算，为 `false` 时停止固定 | `string \| boolean` | `false` | | |||
| | `[nzRight]` | 右侧距离，用于固定右侧列，当为 `true` 时自动计算，为 `false` 时停止固定 | `string \| boolean` | `false` | | |||
| | `[nzAlign]` | 设置列内容的对齐方式 | `'left' \| 'right' \| 'center'` | - | | |||
| | `[nzCustomColumnType]` | 设置列的显示与位置 | `string` | - | | |||
| this.renderer.setStyle(this.el.nativeElement, 'display', 'block'); | ||
| } | ||
| this.renderer.setStyle(this.el.nativeElement, 'order', i); | ||
| this.renderer.setStyle(this.el.nativeElement, 'flex', `1 1 ${v.width}px`); |
There was a problem hiding this comment.
width 可否支持百分比或者 fill / auto，否则在固定列宽的情况下，隐藏一部分列可能会导致 table 宽变窄？
There was a problem hiding this comment.
可以支持固定宽度，但是auto不能支持，同一列的宽度上下是独立的
OriginRing
force-pushed
the
feat/custom-column
branch
2 times, most recently
from
7e9e2c2 to
a8941ad
Compare
OriginRing
force-pushed
the
feat/custom-column
branch
from
a8941ad to
222bb35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information