-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:transfer): fix transfer all selecting cancel event #8872
fix(module:transfer): fix transfer all selecting cancel event #8872
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8872 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 537 537
Lines 18460 18469 +9
Branches 2814 2814
==========================================
+ Hits 16954 16962 +8
- Misses 1204 1205 +1
Partials 302 302 ☔ View full report in Codecov by Sentry. |
全选按钮没有交互效果,不应该触发nzSelectChange吧 |
是的,这里还存在一些问题,我将进一步完善它。 |
10ce9d2
to
c0cec1b
Compare
c0cec1b
to
31c221c
Compare
In addition to the issues mentioned above, I have also discovered another issue: REPRODUTION STEPS
This pull request will solve these issues above and make all selection disbaled when options of list are all disabled |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
REPRODUTION STEPS
nzSelectChange
callback (console.log('nzSelectChange', ret);
), but cancel selecting all can notWhat is the new behavior?
select all or cancel will both trigger
nzSelectChange
callbackDoes this PR introduce a breaking change?
Other information