Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): fix transfer all selecting cancel event #8872

Conversation

WwwHhhYran
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

REPRODUTION STEPS

  • take the basic usage demo for example
  • select all items in left
  • cancel selecting all items in left
  • result: selecting all items can trigger nzSelectChange callback (console.log('nzSelectChange', ret);), but cancel selecting all can not

What is the new behavior?

select all or cancel will both trigger nzSelectChange callback

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@WwwHhhYran WwwHhhYran requested a review from Ricbet as a code owner November 12, 2024 08:36
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (40d466d) to head (b6157da).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8872      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         537      537              
  Lines       18460    18469       +9     
  Branches     2814     2814              
==========================================
+ Hits        16954    16962       +8     
- Misses       1204     1205       +1     
  Partials      302      302              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OriginRing
Copy link
Collaborator

全选按钮没有交互效果,不应该触发nzSelectChange吧

@WwwHhhYran WwwHhhYran closed this Nov 12, 2024
@WwwHhhYran WwwHhhYran reopened this Nov 12, 2024
@WwwHhhYran
Copy link
Contributor Author

全选按钮没有交互效果,不应该触发nzSelectChange吧

是的,这里还存在一些问题,我将进一步完善它。
Yes, there are still some issues here, and I will further improve it.

@WwwHhhYran WwwHhhYran force-pushed the fix/restore_transfer_all_selecting_cancel_event branch from 10ce9d2 to c0cec1b Compare November 13, 2024 03:50
@WwwHhhYran WwwHhhYran force-pushed the fix/restore_transfer_all_selecting_cancel_event branch from c0cec1b to 31c221c Compare November 13, 2024 03:52
@WwwHhhYran
Copy link
Contributor Author

WwwHhhYran commented Nov 13, 2024

In addition to the issues mentioned above, I have also discovered another issue:

REPRODUTION STEPS

  • take the basic usage demo for example
  • check left list option content 2 and then cancel check it, nzSelectChange callback will not trigger when cancel check.
  • re-check left list option content 2, then check content 5, finally cancel check content5 ( but content 2 still selected), nzSelectChange callback will trigger when cancel check content5

This pull request will solve these issues above and make all selection disbaled when options of list are all disabled

@WwwHhhYran
Copy link
Contributor Author

全选按钮没有交互效果,不应该触发nzSelectChange吧

是的,这里还存在一些问题,我将进一步完善它。 Yes, there are still some issues here, and I will further improve it.

done

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 5ff9821 into NG-ZORRO:master Nov 14, 2024
9 of 10 checks passed
@WwwHhhYran WwwHhhYran deleted the fix/restore_transfer_all_selecting_cancel_event branch November 18, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants