Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review the checklist in the pull request template #643

Closed
1 task done
fdiblen opened this issue Aug 29, 2024 · 2 comments
Closed
1 task done

review the checklist in the pull request template #643

fdiblen opened this issue Aug 29, 2024 · 2 comments

Comments

@fdiblen
Copy link
Member

fdiblen commented Aug 29, 2024

Checklist before submitting an issue

  • I have checked the existing issues and couldn't find an issue about this bug.

Issue details

The pull request template has a long checklist which may be overwhelming for some contributor. We should review the check list and make some of the checks optional or remove them.

@egpbos
Copy link
Member

egpbos commented Sep 4, 2024

Imho the whole template should be drastically reduced. Not just for new contributors, but for me as well ;) There is way too much text which obscures the information you need to understand what the PR actually proposes to change. The text in a PR first-post should describe the contributions in the PR. The contributor/reviewer instructions can simply be linked to in a seperate static document in the repo. Checklists can be helpful, but only for crucial issues that actually go wrong often (i.e. to solve actual problems).

@egpbos
Copy link
Member

egpbos commented Sep 18, 2024

Let's continue the discussion in #670?

@egpbos egpbos closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants