Skip to content

Commit 4bd3395

Browse files
committed
Check template exists, remove redundant docker login in EKS job
1 parent d27010a commit 4bd3395

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

.github/workflows/_transformer_engine_eks.yaml

+7-10
Original file line numberDiff line numberDiff line change
@@ -46,30 +46,27 @@ jobs:
4646
steps:
4747
- name: Check out the repository
4848
uses: actions/checkout@v4
49-
- name: Login to GitHub Container Registry
50-
uses: docker/login-action@v3
51-
with:
52-
registry: ghcr.io
53-
username: ${{ github.repository_owner }}
54-
password: ${{ secrets.GITHUB_TOKEN }}
5549
- name: K8s GHCR store and delete token
5650
id: store-token
5751
uses: ./.github/actions/store-delete-k8s-ghcr
5852
- name: Configure job manifest
5953
run: |
54+
set -x
6055
K8S_JOB_TEMPLATE="${{ env.TE_EKS_FILES_PREFIX }}/test.yml"
6156
K8S_JOB_MANIFEST="${{ env.TE_EKS_FILES_PREFIX }}/${{ matrix.TEST }}.yml"
6257
SCRIPT="${{ env.TE_EKS_FILES_PREFIX }}/scripts/${{ matrix.TEST }}.sh"
6358
59+
if ! [ -f $K8S_JOB_TEMPLATE ]; then
60+
echo "Template manifest does not exist at $K8S_JOB_TEMPLATE"
61+
exit 1
62+
fi
63+
6464
# paste in script to manifest from file
65+
# update placeholder values
6566
sed '/SCRIPT/ {
6667
r '$SCRIPT'
6768
d
6869
}' $K8S_JOB_TEMPLATE | \
69-
tee $K8S_JOB_MANIFEST > /dev/null
70-
71-
# update placeholder values
72-
cat $K8S_JOB_MANIFEST | \
7370
sed s@JOB_NAME@${{ env.RUN_NAME }}@g | \
7471
sed s@IMAGE_URI@${{ inputs.JAX_IMAGE }}@g | \
7572
sed s@SECRETS_NAME@${{ steps.store-token.outputs.token-name }}@g | \

0 commit comments

Comments
 (0)