Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement is close operator [FEA] #379

Closed
luitjens opened this issue Feb 10, 2023 · 4 comments · Fixed by #448
Closed

implement is close operator [FEA] #379

luitjens opened this issue Feb 10, 2023 · 4 comments · Fixed by #448

Comments

@luitjens
Copy link
Collaborator

we should implement the isclose operator for comparing tensors.

https://www.w3schools.com/python/ref_math_isclose.asp

@cliffburdick
Copy link
Collaborator

this is really a reduction I think and can already be implemented with all()

@luitjens
Copy link
Collaborator Author

I think we should have isclose(A,B) which returns a boolean tensor of the same size. Then the reduction can be done with all().

@luitjens
Copy link
Collaborator Author

maybe we implement an isclose pointwise operator and allclose reduction?

@cliffburdick
Copy link
Collaborator

cliffburdick commented Feb 10, 2023

Yeah, we probably need two separate versions. I'd imagine almost everyone would want to reduce it afterwards, but look at the larger matrix for statistics or to find where problems are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants