Skip to content

Commit 278d7bb

Browse files
committed
Merge pull request #1229 from mebigfatguy/master
remove dead Setter class
2 parents e5136eb + d91cc74 commit 278d7bb

File tree

1 file changed

+0
-66
lines changed

1 file changed

+0
-66
lines changed

hystrix-core/src/main/java/com/netflix/hystrix/collapser/RequestCollapserFactory.java

-66
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,13 @@
2020
import org.slf4j.Logger;
2121
import org.slf4j.LoggerFactory;
2222

23-
import com.netflix.hystrix.HystrixCollapser;
2423
import com.netflix.hystrix.HystrixCollapserKey;
2524
import com.netflix.hystrix.HystrixCollapserProperties;
2625
import com.netflix.hystrix.strategy.HystrixPlugins;
2726
import com.netflix.hystrix.strategy.concurrency.HystrixConcurrencyStrategy;
2827
import com.netflix.hystrix.strategy.concurrency.HystrixRequestVariableHolder;
2928
import com.netflix.hystrix.strategy.concurrency.HystrixRequestVariableLifecycle;
3029
import com.netflix.hystrix.strategy.properties.HystrixPropertiesFactory;
31-
import com.netflix.hystrix.strategy.properties.HystrixPropertiesStrategy;
3230
import com.netflix.hystrix.util.HystrixTimer;
3331

3432
/**
@@ -217,69 +215,5 @@ public void shutdown(RequestCollapser<BatchReturnType, ResponseType, RequestArgu
217215
}
218216
});
219217
}
220-
221-
}
222-
223-
/**
224-
* Fluent interface for arguments to the {@link HystrixCollapser} constructor.
225-
* <p>
226-
* The required arguments are set via the 'with' factory method and optional arguments via the 'and' chained methods.
227-
* <p>
228-
* Example:
229-
* <pre> {@code
230-
* Setter.withCollapserKey(HystrixCollapserKey.Factory.asKey("CollapserName"))
231-
.andScope(Scope.REQUEST);
232-
* } </pre>
233-
*
234-
* @NotThreadSafe
235-
*/
236-
public static class Setter {
237-
private final HystrixCollapserKey collapserKey;
238-
private Scope scope = Scopes.REQUEST; // default if nothing is set
239-
private HystrixCollapserProperties.Setter propertiesSetter;
240-
241-
private Setter(HystrixCollapserKey collapserKey) {
242-
this.collapserKey = collapserKey;
243-
}
244-
245-
/**
246-
* Setter factory method containing required values.
247-
* <p>
248-
* All optional arguments can be set via the chained methods.
249-
*
250-
* @param collapserKey
251-
* {@link HystrixCollapserKey} that identifies this collapser and provides the key used for retrieving properties, request caches, publishing metrics etc.
252-
* @return Setter for fluent interface via method chaining
253-
*/
254-
public static Setter withCollapserKey(HystrixCollapserKey collapserKey) {
255-
return new Setter(collapserKey);
256-
}
257-
258-
/**
259-
* {@link Scope} defining what scope the collapsing should occur within
260-
*
261-
* @param scope collapser scope
262-
*
263-
* @return Setter for fluent interface via method chaining
264-
*/
265-
public Setter andScope(Scope scope) {
266-
this.scope = scope;
267-
return this;
268-
}
269-
270-
/**
271-
* @param propertiesSetter
272-
* {@link HystrixCollapserProperties.Setter} that allows instance specific property overrides (which can then be overridden by dynamic properties, see
273-
* {@link HystrixPropertiesStrategy} for
274-
* information on order of precedence).
275-
* <p>
276-
* Will use defaults if left NULL.
277-
* @return Setter for fluent interface via method chaining
278-
*/
279-
public Setter andCollapserPropertiesDefaults(HystrixCollapserProperties.Setter propertiesSetter) {
280-
this.propertiesSetter = propertiesSetter;
281-
return this;
282-
}
283-
284218
}
285219
}

0 commit comments

Comments
 (0)