Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hystrix event type for fallback missing #1600

Closed
JagmohanSharma opened this issue Jun 1, 2017 · 6 comments
Closed

Wrong hystrix event type for fallback missing #1600

JagmohanSharma opened this issue Jun 1, 2017 · 6 comments

Comments

@JagmohanSharma
Copy link

JagmohanSharma commented Jun 1, 2017

In my annotated hystrix command I have not defined any fallback method. But when my command execution gets fail, it gives me

 eventNotifier.markEvent(HystrixEventType.FALLBACK_FAILURE, commandKey);

But I think this should be

 eventNotifier.markEvent(HystrixEventType.FALLBACK_MISSING, commandKey);

you have a check here as if (fe instanceof UnsupportedOperationException) {} before making event for FALLBACK_MISSING.

Can somebody confirm whether this is expected? Any help would be appreciated.

@mattrjacobs
Copy link
Contributor

@dmgcodevil Do you know if it is possible to support FALLBACK_MISSING in Javanica?

@dmgcodevil
Copy link
Contributor

@mattrjacobs will take a look shortly

@dmgcodevil
Copy link
Contributor

#1616

@JagmohanSharma
Copy link
Author

JagmohanSharma commented Jun 22, 2017

@dmgcodevil thank you .
I also found the cause and tested yesterday. I was about to provide information here to seek possibilities to contribute :)

@JagmohanSharma
Copy link
Author

@mattrjacobs in which release we can expect to be available ? :)

@mattrjacobs
Copy link
Contributor

This is released in v1.5.13 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants